Fix and improve GitHub Actions release workflow for automated APK builds#3
Conversation
Co-authored-by: dantech0xff <67886170+dantech0xff@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes and improves the existing GitHub Actions release workflow to properly build and attach APKs to repository releases. The workflow had formatting issues and lacked proper error handling that prevented optimal functionality.
- Added comprehensive error handling and debugging capabilities for APK detection
- Fixed YAML formatting issues including indentation, trailing spaces, and added document start marker
- Enhanced build visibility with detailed summaries and improved logging throughout the process
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| echo "Using version from tag: $VERSION" | ||
| else | ||
| VERSION=$(grep 'versionName' app/build.gradle.kts | \ | ||
| sed 's/.*"\(.*\)".*/\1/') | ||
| echo "Using version from gradle: $VERSION" |
There was a problem hiding this comment.
The echo statements for version logging are missing proper indentation. They should be indented to align with the other commands in the conditional blocks to maintain consistent formatting.
| else | ||
| VERSION=$(grep 'versionName' app/build.gradle.kts | \ | ||
| sed 's/.*"\(.*\)".*/\1/') | ||
| echo "Using version from gradle: $VERSION" |
There was a problem hiding this comment.
The echo statements for version logging are missing proper indentation. They should be indented to align with the other commands in the conditional blocks to maintain consistent formatting.
Overview
Fixed the existing GitHub Actions release workflow to properly build and attach release APKs to repository releases. The workflow was previously present but had several formatting and logic issues that prevented optimal functionality.
Changes Made
YAML Formatting & Standards
---)Enhanced Error Handling & Debugging
Build Summary & Visibility
Robust Version Handling
qr-code-scanner-{version}.apkformatWorkflow Features
The workflow now automatically:
v*)Testing
The workflow integrates seamlessly with the existing release script (
scripts/release.sh) and documentation (CICD.md) already present in the repository.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx4096m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.4-bin/1w5dpkrfk8irigvoxmyhowfim/gradle-8.4/lib/gradle-launcher-8.4.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.4-bin/1w5dpkrfk8irigvoxmyhowfim/gradle-8.4/lib/agents/gradle-instrumentation-agent-8.4.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.4(dns block)esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.