Merge pull request #196 from dapi/fix/195-rubyllm-invalidroleerror-webhook

fix: Validate message roles to prevent RubyLLM::InvalidRoleError (#195)

Author: dapi

CLAUDE.md

@@ -166,13 +166,36 @@ bin/rails screenshots:dashboard
 - **При изменениях:** ROADMAP-ARCHIVE.md обновляется
 
 
-# Подключение к production базе для диагностики
+# Production & Kubernetes доступ
+
+**Кластер:** fury (K8s context: `fury`)
+**Namespace:** `valera-production`
+**Deployment:** `valera`
+**Container:** `ror`
+
+## Подключение к production базе для диагностики
 
 Креды для подключения к production postgresql базы для диагностики находятся в
 переменных окружения: PRODUCTION_VALERA_DATABASE_USERNAME, PRODUCTION_VALERA_DATABASE_HOST, PRODUCTION_VALERA_DATABASE_PASSWORD, PRODUCTION_VALERA_DATABASE_NAME
 
 используй их для подключения через psql
 
+## Прямой доступ через kubectl
+
+```bash
+# Rails Console
+kubectl --context=fury -n valera-production exec -it deploy/valera -c ror -- bundle exec rails console
+
+# Rails Runner
+kubectl --context=fury -n valera-production exec deploy/valera -c ror -- bundle exec rails runner 'puts User.count'
+
+# Проверка подов
+kubectl --context=fury -n valera-production get pods
+
+# Логи
+kubectl --context=fury -n valera-production logs deploy/valera -c ror --tail=100
+```
+
 # Авторизация в SaaS для диагностики в разработке
 
 Доступ в administarte осуществляется через playwright mcp по адресу указанном в переменной окружения

app/models/message.rb

@@ -2,6 +2,11 @@
 
 # Represents a single message within a chat conversation
 class Message < ApplicationRecord
+  # Valid message roles: RubyLLM::Message::ROLES + app-specific roles (manager).
+  VALID_ROLES = %w[system user assistant tool manager].freeze
+
   acts_as_message touch_chat: :last_message_at
   has_many_attached :attachments
+
+  validates :role, presence: true, inclusion: { in: VALID_ROLES }
 end

app/views/landing/lp1.html.slim

@@ -441,7 +441,7 @@ section#form.py-20.md:py-32.bg-gradient-to-br.from-gray-900.via-blue-900.to-gray
 
           div
             = f.label :phone, "Телефон", class: "block text-sm font-semibold text-gray-700 mb-2"
-            = f.telephone_field :phone, class: "w-full px-4 py-4 text-lg border-2 border-gray-200 rounded-xl focus:ring-2 focus:ring-blue-500 focus:border-blue-500 bg-gray-50 placeholder-gray-400 text-gray-900", placeholder: "+7 (999) 123-45-67", required: true, inputmode: "tel", autofocus: true
+            = f.telephone_field :phone, class: "w-full px-4 py-4 text-lg border-2 border-gray-200 rounded-xl focus:ring-2 focus:ring-blue-500 focus:border-blue-500 bg-gray-50 placeholder-gray-400 text-gray-900", placeholder: "+7 (999) 123-45-67", required: true, inputmode: "tel"
 
           div
             = f.label :name, "Ваше имя", class: "block text-sm font-semibold text-gray-700 mb-2"

app/views/landing/lp_magic_1.html.slim

@@ -556,7 +556,7 @@ section#form.py-20.md:py-32.bg-gradient-to-br.from-slate-900.via-blue-900.to-sla
 
             div
               = f.label :phone, "Телефон", class: "block text-sm font-semibold text-slate-700 mb-2"
-              = f.telephone_field :phone, class: "w-full px-4 py-4 text-lg border-2 border-slate-200 rounded-xl focus:ring-2 focus:ring-blue-500 focus:border-blue-500 bg-slate-50 placeholder-slate-400 text-slate-900 transition-all", placeholder: "+7 (999) 123-45-67", required: true, inputmode: "tel", autofocus: true
+              = f.telephone_field :phone, class: "w-full px-4 py-4 text-lg border-2 border-slate-200 rounded-xl focus:ring-2 focus:ring-blue-500 focus:border-blue-500 bg-slate-50 placeholder-slate-400 text-slate-900 transition-all", placeholder: "+7 (999) 123-45-67", required: true, inputmode: "tel"
 
             div
               = f.label :name, "Ваше имя", class: "block text-sm font-semibold text-slate-700 mb-2"

app/views/landing/lp_magic_2.html.slim

@@ -426,7 +426,7 @@ section#form.py-28.lg:py-36.bg-gradient-to-br.from-blue-600.via-blue-700.to-blue
         = f.hidden_field :utm_campaign, data: { utm_target: "campaign" }
 
         / Phone input - large
-        = f.telephone_field :phone, class: "w-full px-6 py-5 text-lg border-2 border-slate-200 rounded-2xl focus:ring-4 focus:ring-blue-100 focus:border-blue-500 bg-slate-50 text-slate-900 transition-all placeholder-slate-400", placeholder: "+7 (999) 123-45-67", required: true, inputmode: "tel", autofocus: true
+        = f.telephone_field :phone, class: "w-full px-6 py-5 text-lg border-2 border-slate-200 rounded-2xl focus:ring-4 focus:ring-blue-100 focus:border-blue-500 bg-slate-50 text-slate-900 transition-all placeholder-slate-400", placeholder: "+7 (999) 123-45-67", required: true, inputmode: "tel"
 
         / Submit button
         = f.submit "Жду звонка", class: "w-full bg-blue-600 text-white font-bold py-5 rounded-2xl text-lg hover:bg-blue-700 active:bg-blue-800 transition-all cursor-pointer shadow-lg shadow-blue-600/30 hover:shadow-xl hover:shadow-blue-600/40 hover:-translate-y-0.5"

app/views/landing/lp_magic_3.html.slim

@@ -403,7 +403,7 @@ section#form.py-20.bg-gradient-to-br.from-orange-500.to-red-600.text-white.relat
 
           div
             = f.label :phone, "Телефон", class: "block text-sm font-semibold text-slate-700 mb-2"
-            = f.telephone_field :phone, class: "w-full px-4 py-4 text-lg border-2 border-slate-200 rounded-xl focus:ring-2 focus:ring-orange-500 focus:border-orange-500 bg-slate-50 text-slate-900", placeholder: "+7 (999) 123-45-67", required: true, inputmode: "tel", autofocus: true
+            = f.telephone_field :phone, class: "w-full px-4 py-4 text-lg border-2 border-slate-200 rounded-xl focus:ring-2 focus:ring-orange-500 focus:border-orange-500 bg-slate-50 text-slate-900", placeholder: "+7 (999) 123-45-67", required: true, inputmode: "tel"
 
           div
             = f.label :name, "Ваше имя", class: "block text-sm font-semibold text-slate-700 mb-2"

app/views/landing/show.html.slim

@@ -163,7 +163,7 @@ section#form.py-16.md:py-20.px-4.bg-blue-600.text-white
         .space-y-5
           div.text-left
             = f.label :phone, "Телефон", class: "block text-sm font-semibold text-gray-700 mb-2"
-            = f.telephone_field :phone, class: "w-full px-4 py-4 text-lg border-2 border-gray-300 rounded-xl focus:ring-2 focus:ring-blue-500 focus:border-blue-500 bg-gray-50 placeholder-gray-400", placeholder: "+7 (999) 123-45-67", required: true, inputmode: "tel", autofocus: true
+            = f.telephone_field :phone, class: "w-full px-4 py-4 text-lg border-2 border-gray-300 rounded-xl focus:ring-2 focus:ring-blue-500 focus:border-blue-500 bg-gray-50 placeholder-gray-400", placeholder: "+7 (999) 123-45-67", required: true, inputmode: "tel"
 
           div.text-left
             = f.label :name, "Ваше имя", class: "block text-sm font-semibold text-gray-700 mb-2"

bin/production-rails-runner

@@ -13,7 +13,8 @@
 
 set -euo pipefail
 
-NAMESPACE="${PRODUCTION_NAMESPACE:-production}"
+CONTEXT="${PRODUCTION_CONTEXT:-fury}"
+NAMESPACE="${PRODUCTION_NAMESPACE:-valera-production}"
 DEPLOYMENT="${PRODUCTION_DEPLOYMENT:-valera}"
 CONTAINER="${PRODUCTION_CONTAINER:-ror}"
 
@@ -30,10 +31,10 @@ fi
 
 if [[ "$1" == "-" ]]; then
   # Read from stdin
-  kubectl exec -i -n "$NAMESPACE" "deployment/$DEPLOYMENT" -c "$CONTAINER" -- \
+  kubectl --context="$CONTEXT" exec -i -n "$NAMESPACE" "deployment/$DEPLOYMENT" -c "$CONTAINER" -- \
     bundle exec rails runner -
 else
   # Pass argument directly
-  kubectl exec -n "$NAMESPACE" "deployment/$DEPLOYMENT" -c "$CONTAINER" -- \
+  kubectl --context="$CONTEXT" exec -n "$NAMESPACE" "deployment/$DEPLOYMENT" -c "$CONTAINER" -- \
     bundle exec rails runner "$1"
 fi

test/models/message_test.rb

@@ -8,4 +8,40 @@ class MessageTest < ActiveSupport::TestCase
     assert message.valid?
     assert message.persisted?
   end
+
+  test 'valid roles are accepted' do
+    chat = chats(:one)
+    Message::VALID_ROLES.each do |role|
+      message = Message.new(chat: chat, role: role, content: 'Test content')
+      assert message.valid?, "Role '#{role}' should be valid but got errors: #{message.errors.full_messages}"
+    end
+  end
+
+  test 'invalid role is rejected' do
+    chat = chats(:one)
+    message = Message.new(chat: chat, role: 'invalid_role', content: 'Test content')
+    assert_not message.valid?
+    assert message.errors[:role].any?
+  end
+
+  test 'empty role is rejected' do
+    chat = chats(:one)
+    message = Message.new(chat: chat, role: '', content: 'Test content')
+    assert_not message.valid?
+    assert message.errors[:role].any?
+  end
+
+  test 'nil role is rejected' do
+    chat = chats(:one)
+    message = Message.new(chat: chat, role: nil, content: 'Test content')
+    assert_not message.valid?
+    assert message.errors[:role].any?
+  end
+
+  test 'VALID_ROLES includes all RubyLLM roles' do
+    llm_roles = RubyLLM::Message::ROLES.map(&:to_s)
+    missing = llm_roles - Message::VALID_ROLES
+    assert missing.empty?,
+      "Message::VALID_ROLES is missing RubyLLM roles: #{missing.join(', ')}"
+  end
 end