Skip to content

fix: allow workflow_dispatch for v1.16 SWA deployment#5134

Merged
marcduiker merged 2 commits into
v1.16from
fix/workflow-dispatch-v1-16
Apr 24, 2026
Merged

fix: allow workflow_dispatch for v1.16 SWA deployment#5134
marcduiker merged 2 commits into
v1.16from
fix/workflow-dispatch-v1-16

Conversation

@paulyuk

@paulyuk paulyuk commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Problem

The build job condition only allows push and pull_request events:

if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed')

workflow_dispatch is excluded, so manual triggers skip the build.

Fix

Use the same condition as website-root.yml:

if: github.event.action != 'closed'

This works for all event types (push, pull_request, workflow_dispatch) and only skips the closed PR action.

Context

Needed after migrating SWAs to the new Azure subscription. When merged, the push event will trigger deployment to the new SWA.

@paulyuk paulyuk requested review from a team as code owners April 21, 2026 23:43
@paulyuk paulyuk force-pushed the fix/workflow-dispatch-v1-16 branch 9 times, most recently from a99d89d to 066f439 Compare April 22, 2026 07:55
Signed-off-by: paulyuk <paulyuk@microsoft.com>
@paulyuk paulyuk force-pushed the fix/workflow-dispatch-v1-16 branch from 066f439 to 75edf59 Compare April 22, 2026 08:00

@marcduiker marcduiker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-mud-01247fe1e-5134.westus2.7.azurestaticapps.net

@marcduiker marcduiker merged commit 8b24062 into v1.16 Apr 24, 2026
4 checks passed
@marcduiker marcduiker deleted the fix/workflow-dispatch-v1-16 branch June 12, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants