Skip to content

Commit 105d631

Browse files
cicoyleCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Cassie Coyle <cassie.i.coyle@gmail.com>
1 parent 836ee5d commit 105d631

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

examples/jobs/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ The callback service must:
252252
- The Jobs API is **stable** as of Dapr 1.18 (the SDK falls back to the `*_alpha1` RPCs on older sidecars)
253253
- Jobs are persistent and will survive Dapr sidecar restarts
254254
- Job names must be unique within the Dapr application
255-
- Both `schedule` and `due_time` are optional - if neither is provided, the job will trigger immediately
255+
- At least one of `schedule` or `due_time` must be provided when scheduling a job
256256
- Requires Dapr runtime v1.14+ for Jobs API support
257257

258258
For more information about the Jobs API, see:

tests/clients/fake_dapr_server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,7 @@ def _schedule_job(self, request, context):
598598
self.jobs[request.job.name] = request.job
599599
self.job_overwrites[request.job.name] = request.overwrite
600600

601-
return empty_pb2.Empty()
601+
return api_v1.ScheduleJobResponse()
602602

603603
def _get_job(self, request, context):
604604
self.check_for_exception(context)
@@ -620,7 +620,7 @@ def _delete_job(self, request, context):
620620
if request.name in self.jobs:
621621
del self.jobs[request.name]
622622

623-
return empty_pb2.Empty()
623+
return api_v1.DeleteJobResponse()
624624

625625
def ScheduleJob(self, request, context):
626626
self._reject_if_alpha_only(context)

0 commit comments

Comments
 (0)