Skip to content

Commit 227821f

Browse files
committed
Address PR feedback (2)
Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>
1 parent 97a1c28 commit 227821f

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

tests/integration/conftest.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
T = TypeVar('T')
1717

1818
INTEGRATION_DIR = Path(__file__).resolve().parent
19-
COMPONENTS_DIR = INTEGRATION_DIR / 'components'
19+
RESOURCES_DIR = INTEGRATION_DIR / 'resources'
2020
APPS_DIR = INTEGRATION_DIR / 'apps'
2121

2222

@@ -27,7 +27,7 @@ class DaprTestEnvironment:
2727
class returns real DaprClient instances so tests can make assertions against SDK return values.
2828
"""
2929

30-
def __init__(self, default_components: Path = COMPONENTS_DIR) -> None:
30+
def __init__(self, default_components: Path = RESOURCES_DIR) -> None:
3131
self._default_components = default_components
3232
self._processes: list[subprocess.Popen[str]] = []
3333
self._clients: list[DaprClient] = []
@@ -118,15 +118,15 @@ def cleanup(self) -> None:
118118

119119

120120
def _wait_until(
121-
predicate: Callable[[], T | None],
121+
condition: Callable[[], T | None],
122122
timeout: float = 10.0,
123123
interval: float = 0.1,
124124
) -> T:
125125
"""Poll `predicate` until it returns a truthy value.
126126
Raises `TimeoutError` if it never returns."""
127127
deadline = time.monotonic() + timeout
128128
while True:
129-
result = predicate()
129+
result = condition()
130130
if result:
131131
return result
132132
if time.monotonic() >= deadline:
@@ -211,4 +211,4 @@ def apps_dir() -> Path:
211211

212212
@pytest.fixture(scope='module')
213213
def components_dir() -> Path:
214-
return COMPONENTS_DIR
214+
return RESOURCES_DIR

0 commit comments

Comments
 (0)