fix: address copilot feedback

Signed-off-by: Samantha Coyle <sam@diagrid.io>

Author: sicoyle

.github/workflows/build.yaml

@@ -70,10 +70,11 @@ jobs:
     # Install and run the durabletask-go sidecar for running e2e tests
     - name: Pytest e2e tests for DurableTask Python
       run: |
-        # TODO: use dapr run instead of durabletask-go as it provides a more reliable sidecar behaviorfor e2e tests  
-        go install github.com/dapr/durabletask-go@main        
-        durabletask-go --port 4001 & cd durabletask && \
-        tox -e py${{ matrix.python-version }}-e2e
+        # TODO: use dapr run instead of durabletask-go as it provides a more reliable sidecar behavior for e2e tests
+        go install github.com/dapr/durabletask-go@main
+        durabletask-go --port 4001 &
+        pip install -e durabletask[dev]
+        pytest -m e2e durabletask_tests/
     - name: Run examples
       run: |
         pip install mechanical-markdown

.github/workflows/durabletask-validation.yml

@@ -28,13 +28,13 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
-        pip install .[dev]
+        pip install -e durabletask[dev]
     - name: Lint with ruff
       run: |
-        ruff check
+        ruff check durabletask/ durabletask_tests/
     - name: Pytest unit tests
       run: |
-        tox -e py${{ matrix.python-version }}
+        pytest -m "not e2e" durabletask_tests/
     # Sidecar for running e2e tests requires Go SDK
     - name: Install Go SDK
       uses: actions/setup-go@v5
@@ -43,11 +43,10 @@ jobs:
     # Install and run the durabletask-go sidecar for running e2e tests
     - name: Pytest e2e tests
       run: |
-        # TODO: use dapr run instead of durabletask-go as it provides a more reliable sidecar behaviorfor e2e tests  
-        go install github.com/dapr/durabletask-go@main        
+        # TODO: use dapr run instead of durabletask-go as it provides a more reliable sidecar behavior for e2e tests
+        go install github.com/dapr/durabletask-go@main
         durabletask-go --port 4001 &
-        cd durabletask
-        tox -e py${{ matrix.python-version }}-e2e
+        pytest -m e2e durabletask_tests/
     - name: Run examples
       run: |
         pip install mechanical-markdown

durabletask/README.md

@@ -65,7 +65,7 @@ def sequence(ctx: task.OrchestrationContext, _):
     return [result1, result2, result3]
 ```
 
-You can find the full sample [here](./examples/activity_sequence.py).
+You can find the full sample [here](../durabletask_examples/activity_sequence.py).
 
 ### Fan-out/fan-in
 
@@ -93,11 +93,11 @@ def orchestrator(ctx: task.OrchestrationContext, _):
     return {'work_items': work_items, 'results': results, 'total': sum(results)}
 ```
 
-You can find the full sample [here](./examples/fanout_fanin.py).
+You can find the full sample [here](../durabletask_examples/fanout_fanin.py).
 
 ### Human interaction and durable timers
 
-An orchestration can wait for a user-defined event, such as a human approval event, before proceding to the next step. In addition, the orchestration can create a timer with an arbitrary duration that triggers some alternate action if the external event hasn't been received:
+An orchestration can wait for a user-defined event, such as a human approval event, before proceeding to the next step. In addition, the orchestration can create a timer with an arbitrary duration that triggers some alternate action if the external event hasn't been received:
 
 ```python
 def purchase_order_workflow(ctx: task.OrchestrationContext, order: Order):
@@ -124,7 +124,7 @@ def purchase_order_workflow(ctx: task.OrchestrationContext, order: Order):
 
 As an aside, you'll also notice that the example orchestration above works with custom business objects. Support for custom business objects includes support for custom classes, custom data classes, and named tuples. Serialization and deserialization of these objects is handled automatically by the SDK.
 
-You can find the full sample [here](./examples/human_interaction.py).
+You can find the full sample [here](../durabletask_examples/human_interaction.py).
 
 ## Feature overview
 

durabletask/internal/shared.py

@@ -113,10 +113,16 @@ def get_logger(
 ) -> logging.Logger:
     logger = logging.getLogger(f"durabletask-{name_suffix}")
 
-    # Add a default log handler if none is provided
+    # Add a log handler only if one is not already present, to avoid duplicate log lines
+    # when get_logger is called multiple times for the same logger name.
     if log_handler is None:
-        log_handler = logging.StreamHandler()
-    logger.handlers.append(log_handler)
+        if not logger.handlers:
+            log_handler = logging.StreamHandler()
+            logger.addHandler(log_handler)
+        else:
+            log_handler = logger.handlers[0]
+    elif log_handler not in logger.handlers:
+        logger.addHandler(log_handler)
 
     # Set a default log formatter to our handler if none is provided
     if log_formatter is None:

durabletask/pyproject.toml

@@ -27,7 +27,6 @@ readme = "README.md"
 dependencies = [
     "grpcio",
     "protobuf>=6.31.1,<7.0.0", # follows grpcio generation version https://github.com/grpc/grpc/blob/v1.75.1/tools/distrib/python/grpcio_tools/setup.py
-    "asyncio"
 ]
 
 [project.urls]

durabletask/task.py

@@ -158,7 +158,7 @@ def call_sub_orchestrator(
         """
         pass
 
-    # TOOD: Add a timeout parameter, which allows the task to be canceled if the event is
+    # TODO: Add a timeout parameter, which allows the task to be canceled if the event is
     # not received within the specified timeout. This requires support for task cancellation.
     @abstractmethod
     def wait_for_external_event(self, name: str) -> Task:
@@ -352,7 +352,9 @@ def pending_tasks(self) -> int:
 
     def on_child_completed(self, task: Task[T]):
         if self.is_complete:
-            raise ValueError("The task has already completed.")
+            # A prior child failure may have already completed this composite task.
+            # Ignore late child completions rather than crashing the orchestration runner.
+            return
         self._completed_tasks += 1
         if task.is_failed and self._exception is None:
             self._exception = task.get_exception()

durabletask_examples/fanout_fanin.py

@@ -1,5 +1,5 @@
 """End-to-end sample that demonstrates how to configure an orchestrator
-that a dynamic number activity functions in parallel, waits for them all
+that runs a dynamic number of activity functions in parallel, waits for them all
 to complete, and prints an aggregate summary of the outputs."""
 
 import random

durabletask_examples/human_interaction.py

@@ -1,5 +1,5 @@
 """End-to-end sample that demonstrates how to configure an orchestrator
-that waits for an "approval" event before proceding to the next step. If
+that waits for an "approval" event before proceeding to the next step. If
 the approval isn't received within a specified timeout, the order that is
 represented by the orchestration is automatically cancelled."""
 

durabletask_tests/durabletask/test_orchestration_e2e.py

@@ -351,7 +351,7 @@ def parent_orchestrator(ctx: task.OrchestrationContext, count: int):
 
                 time.sleep(1)  # Brief delay to let orchestrations start
 
-                output = "Recursive termination = {recurse}"
+                output = f"Recursive termination = {recurse}"
                 task_hub_client.terminate_orchestration(
                     instance_id, output=output, recursive=recurse
                 )

durabletask_tests/durabletask/test_registry.py

@@ -185,24 +185,24 @@ def orchestrator3(ctx, input):
     )
     registry.add_named_orchestrator(name="orchestrator", fn=orchestrator3, version_name="v3")
 
-    orquestrator, version = registry.get_orchestrator(name="orchestrator")
-    assert orquestrator is orchestrator2
+    orchestrator, version = registry.get_orchestrator(name="orchestrator")
+    assert orchestrator is orchestrator2
     assert version == "v2"
 
-    orquestrator, version = registry.get_orchestrator(name="orchestrator", version_name="v1")
-    assert orquestrator is orchestrator1
+    orchestrator, version = registry.get_orchestrator(name="orchestrator", version_name="v1")
+    assert orchestrator is orchestrator1
     assert version == "v1"
 
-    orquestrator, version = registry.get_orchestrator(name="orchestrator", version_name="v2")
-    assert orquestrator is orchestrator2
+    orchestrator, version = registry.get_orchestrator(name="orchestrator", version_name="v2")
+    assert orchestrator is orchestrator2
     assert version == "v2"
 
-    orquestrator, version = registry.get_orchestrator(name="orchestrator", version_name="v3")
-    assert orquestrator is orchestrator3
+    orchestrator, version = registry.get_orchestrator(name="orchestrator", version_name="v3")
+    assert orchestrator is orchestrator3
     assert version == "v3"
 
     with pytest.raises(worker.VersionNotRegisteredException):
         registry.get_orchestrator(name="orchestrator", version_name="v4")
 
-    orquestrator, _ = registry.get_orchestrator(name="non-existent")
-    assert orquestrator is None
+    orchestrator, _ = registry.get_orchestrator(name="non-existent")
+    assert orchestrator is None