fix(grpc): allow multiple wildcard subscriptions when topic validation disabled#1083
Open
Rishabh-git10 wants to merge 1 commit into
Open
fix(grpc): allow multiple wildcard subscriptions when topic validation disabled#1083Rishabh-git10 wants to merge 1 commit into
Rishabh-git10 wants to merge 1 commit into
Conversation
…n disabled Signed-off-by: Rishabh Dewangan <107680241+Rishabh-git10@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a
ValueErrorstartup crash and subscription drop when registering multiple wildcard paths on the same pub/sub component withdisable_topic_validation=True.Previously, enabling this flag collapsed internal tracking keys down to the pub/sub identifier alone, causing map collisions and rendering the sidecar blind to subsequent subscriptions. This change standardizes discrete internal dictionary keys across all registration paths. It introduces a regex-based pattern matching fallback evaluation inside
OnTopicEventand_handle_bulk_topic_eventto route events when direct string lookups fail.Issue reference
Closes #436
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: