tests: Fix database connection errors by adding shared conftest fixture

Author: darestack

tests/conftest.py

@@ -0,0 +1,62 @@
+import os
+import pytest
+from sqlalchemy.ext.asyncio import AsyncSession, async_sessionmaker, create_async_engine
+from sqlmodel import SQLModel
+
+from src.core.config import settings
+from src.core import database
+
+# Test Database URL
+TEST_DATABASE_URL = "sqlite+aiosqlite:///test_commitguard.db"
+
+@pytest.fixture(autouse=True, scope="session")
+def override_db_url():
+    """Override database URL for the entire test session."""
+    original_url = settings.DATABASE_URL
+    settings.DATABASE_URL = TEST_DATABASE_URL
+    yield
+    settings.DATABASE_URL = original_url
+
+@pytest.fixture(autouse=True)
+async def setup_test_db():
+    """Initialize test database before each test."""
+    # Ensure database engine and session maker use the test URL
+    original_engine = database.engine
+    original_session_local = database.AsyncSessionLocal
+
+    database.engine = create_async_engine(TEST_DATABASE_URL)
+    new_session_local = async_sessionmaker(
+        bind=database.engine,
+        class_=AsyncSession,
+        expire_on_commit=False,
+        autoflush=False,
+    )
+    database.AsyncSessionLocal = new_session_local
+
+    # Patch src.agents.learning if it's already imported
+    import sys
+    if "src.agents.learning" in sys.modules:
+        import src.agents.learning
+        src.agents.learning.AsyncSessionLocal = new_session_local
+
+    async with database.engine.begin() as conn:
+        await conn.run_sync(SQLModel.metadata.create_all)
+
+    yield
+
+    async with database.engine.begin() as conn:
+        await conn.run_sync(SQLModel.metadata.drop_all)
+
+    await database.engine.dispose()
+    database.engine = original_engine
+    database.AsyncSessionLocal = original_session_local
+    
+    if "src.agents.learning" in sys.modules:
+        import src.agents.learning
+        src.agents.learning.AsyncSessionLocal = original_session_local
+
+    if os.path.exists("test_commitguard.db"):
+        try:
+            os.remove("test_commitguard.db")
+        except PermissionError:
+            pass

tests/test_database.py

@@ -1,10 +1,5 @@
-import os
-
 import pytest
-from sqlalchemy.ext.asyncio import AsyncSession, async_sessionmaker, create_async_engine
-from sqlmodel import SQLModel
 
-from src.core.config import settings
 from src.core.database import (
     get_user_by_git_email,
     get_user_reliability,
@@ -14,44 +9,7 @@
     update_user_reliability,
 )
 
-# Test Database URL
-TEST_DATABASE_URL = "sqlite+aiosqlite:///test_commitguard.db"
-
-
-@pytest.fixture(autouse=True)
-async def setup_test_db():
-    # Override settings for testing
-    original_url = settings.DATABASE_URL
-    settings.DATABASE_URL = TEST_DATABASE_URL
-
-    from src.core import database
-
-    original_engine = database.engine
-    original_session_local = database.AsyncSessionLocal
-
-    database.engine = create_async_engine(TEST_DATABASE_URL)
-    database.AsyncSessionLocal = async_sessionmaker(
-        bind=database.engine,
-        class_=AsyncSession,
-        expire_on_commit=False,
-        autoflush=False,
-    )
-
-    async with database.engine.begin() as conn:
-        await conn.run_sync(SQLModel.metadata.create_all)
-
-    yield
-
-    async with database.engine.begin() as conn:
-        await conn.run_sync(SQLModel.metadata.drop_all)
-
-    await database.engine.dispose()
-    database.engine = original_engine
-    database.AsyncSessionLocal = original_session_local
-    settings.DATABASE_URL = original_url
-
-    if os.path.exists("test_commitguard.db"):
-        os.remove("test_commitguard.db")
+# Using shared setup_test_db fixture from conftest.py
 
 
 @pytest.mark.asyncio

tests/test_roadmap.py

@@ -3,20 +3,8 @@
 from src.agents.brain import CommitGuardBrain
 from src.agents.safety import SafetySupervisor
 from src.agents.learning import SupervisorFeedbackLoop
-from src.schemas.agents import ToneType, SafetyAudit, SafetyFeedback
-from src.core.database import init_db
-
-
-@pytest.fixture(autouse=True)
-async def setup_db():
-    """Ensure database is initialized and clean."""
-    await init_db()
-    from src.core.database import AsyncSessionLocal
-    from sqlmodel import delete
-
-    async with AsyncSessionLocal() as session:
-        await session.execute(delete(SafetyFeedback))
-        await session.commit()
+from src.schemas.agents import ToneType, SafetyAudit
+# Using shared setup_test_db fixture from conftest.py
 
 
 @pytest.mark.asyncio