added objects duplication syntax highlighting

Author: darginmathi

config.json

@@ -2,7 +2,7 @@
 from .model import TableModel
 
 from PyQt6.QtCore import QModelIndex, Qt
-from typing import Optional
+from typing import Optional, Any
 
 class ObjRepoModel(TableModel):
 
@@ -50,6 +50,25 @@ def setData(self, index, value, role=Qt.ItemDataRole.EditRole):
                     break
         return result
 
+    def headerData(self, section: int, orientation: Qt.Orientation, role: int = Qt.ItemDataRole.DisplayRole) -> Any:
+        if role == Qt.ItemDataRole.DisplayRole and orientation == Qt.Orientation.Vertical:
+            return str(section + 1)
+        return super().headerData(section, orientation, role)
+
+    def get_duplicate_names(self):
+        if self.df.empty:
+            return set()
+        # Ensure we're working with string types, and handle potential float NaNs
+        names = self.df.iloc[:, self.NAME_COL].astype(str)
+        # Filter out empty strings and 'END'
+        names = names[names.str.strip() != '']
+        names = names[names != 'END']
+        names = names[names != 'User friendly name of Object']
+        
+        # Find duplicates
+        duplicates = names[names.duplicated()].unique()
+        return set(duplicates)
+
     def insertRows(self, position, rows, parent=QModelIndex()):
         success = super().insertRows(position, rows, parent)
         if success:
@@ -61,7 +80,7 @@ def insertRows(self, position, rows, parent=QModelIndex()):
                     if row_index < len(self.df):
                         self.df.iat[row_index, self.XPATH_COL] = "XPATH"
                         self.dataChanged.emit(xpath_index, xpath_index, [Qt.ItemDataRole.EditRole])
-                self.layoutChangedSignal.emit()
+                self.layoutChanged.emit()
             except Exception as e:
                     print(f"Error setting type or updating IDs after insert: {e}")
                     return False

models/obj_repo.py

@@ -16,6 +16,8 @@ def __init__(self, parent, undo_stack, commands, colors):
         self.colors = colors
         self.cached_objects = []  # Cache for objects
         self.objects_dirty = True
+        self.duplicate_names_cache = set()
+        self.duplicate_names_dirty = True
 
         self.editor = None
         self.current_model = None
@@ -188,6 +190,9 @@ def update_command_list(self, new_commands):
     def invalidate_objects_cache(self):
         self.objects_dirty = True
 
+    def invalidate_duplicate_names_cache(self):
+        self.duplicate_names_dirty = True
+
     def _get_objects(self):
         if self.objects_dirty:
             obj_repo_model = self.parent_tab.model2
@@ -199,6 +204,12 @@ def _get_objects(self):
             self.objects_dirty = False
         return self.cached_objects
 
+    def _get_duplicate_names(self, model):
+        if self.duplicate_names_dirty:
+            self.duplicate_names_cache = model.get_duplicate_names()
+            self.duplicate_names_dirty = False
+        return self.duplicate_names_cache
+
     def paint(self, painter, option, index):
         model = index.model()
         current_row = index.row()
@@ -235,18 +246,26 @@ def paint(self, painter, option, index):
 
         final_color = option.palette.color(QPalette.ColorRole.Text)
 
-        if not is_special_row and isinstance(model, TestScenarioModel):
-            value = index.data(Qt.ItemDataRole.DisplayRole)
-
-            if value:
-                if current_col == TestScenarioModel.COMMAND_COL:
-                    if value not in self.commands:
-                        final_color = QColor("#E57373")
-
-                elif TestScenarioModel.DATA1_COL <= current_col <= TestScenarioModel.DATA5_COL:
-                    objects = self._get_objects()
-                    if value not in objects:
-                        final_color = QColor("#64B5F6")
+        if not is_special_row:
+            if isinstance(model, TestScenarioModel):
+                value = index.data(Qt.ItemDataRole.DisplayRole)
+
+                if value:
+                    if current_col == TestScenarioModel.COMMAND_COL:
+                        if value not in self.commands:
+                            final_color = QColor("#E57373")
+
+                    elif TestScenarioModel.DATA1_COL <= current_col <= TestScenarioModel.DATA5_COL:
+                        objects = self._get_objects()
+                        if value not in objects:
+                            final_color = QColor("#64B5F6")
+            elif isinstance(model, ObjRepoModel):
+                if current_col == ObjRepoModel.NAME_COL:
+                    value = index.data(Qt.ItemDataRole.DisplayRole)
+                    if value:
+                        duplicate_names = self._get_duplicate_names(model)
+                        if value in duplicate_names:
+                            final_color = QColor("#E57373")
 
         option.palette.setColor(QPalette.ColorRole.Text, final_color)
         option.palette.setColor(QPalette.ColorRole.HighlightedText, final_color)

ui/delegates.py

@@ -30,7 +30,7 @@ def __init__(self, module_name, main, project_name=None):
         self.delegate = ComboBoxDelegate(self, self.undo_stack, commands, colors)
 
         self.table1 = Table(model=self.model1, undo_stack=self.undo_stack, delegate=self.delegate, parent_tab=self)
-        self.table2 = Table(model=self.model2, undo_stack=self.undo_stack, delegate=self.delegate)
+        self.table2 = Table(model=self.model2, undo_stack=self.undo_stack, delegate=self.delegate, show_vertical_header=True)
 
         self.controller = TableController(main, self.undo_stack)
 
@@ -128,6 +128,7 @@ def update_delegate_commands(self, commands):
 
     def on_object_model_changed(self):
         self.delegate.invalidate_objects_cache()
+        self.delegate.invalidate_duplicate_names_cache()
 
     def is_object_in_repository(self, object_name):
         if not object_name:

ui/tab.py

@@ -13,12 +13,13 @@ class Table(QWidget):
     skipRequested = pyqtSignal(list)
     unskipRequested = pyqtSignal(list)
 
-    def __init__(self, model, undo_stack=None, delegate=None, parent_tab=None):
+    def __init__(self, model, undo_stack=None, delegate=None, parent_tab=None, show_vertical_header=False):
         super().__init__()
         self.model = model
         self.undo_stack = undo_stack
         self.delegate = delegate
         self.parent_tab = parent_tab
+        self.show_vertical_header = show_vertical_header
 
         layout = QVBoxLayout()
         layout.setContentsMargins(0, 0, 0, 0)
@@ -39,7 +40,8 @@ def setup_table(self):
         v_header = self.table.verticalHeader()
         h_header.setSectionResizeMode(QHeaderView.ResizeMode.Interactive)
         h_header.setMinimumHeight(20)
-        v_header.hide()
+        if not self.show_vertical_header:
+            v_header.hide()
         self.auto_adjust_cells()
         self.table.setWordWrap(True)
         self.table.setAlternatingRowColors(False)