Draft: Cookie Control rewrite (use new dialog component)#233
Draft
raphaelbernhart wants to merge 5 commits into
Draft
Draft: Cookie Control rewrite (use new dialog component)#233raphaelbernhart wants to merge 5 commits into
raphaelbernhart wants to merge 5 commits into
Conversation
Author
|
@dargmuesli Here is a preview of the mentioned issues. This is not ready so keep in mind that maybe not everything is working. not included so far:
what is included:
Preview: https://stackblitz.com/~/github.com/raphaelbernhart/nuxt-cookie-control Please check the preview and give feedback, thanks :) |
dargmuesli
reviewed
Sep 18, 2024
dargmuesli
left a comment
dargmuesli
left a comment
Owner
There was a problem hiding this comment.
Great! Keep on rocking this 🤟
Comment on lines
+57
to
+71
| // module configuration | ||
| exposeConfig: true, | ||
| viewer: false, | ||
| config: { | ||
| theme: { | ||
| extend: { | ||
| colors: moduleOptions.colors as unknown as any, | ||
| }, | ||
| }, | ||
| darkMode: 'class', | ||
| content: [ | ||
| resolver.resolve('./runtime/**/*.{vue,mjs,ts}'), | ||
| resolver.resolve('./runtime/*.{mjs,js,ts}'), | ||
| ], | ||
| }, |
Owner
There was a problem hiding this comment.
Does this config merge with a user's tailwind configuration in the downstream projects?
Author
There was a problem hiding this comment.
This is one of the main things I still have to check. Not sure atm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT:
This MR is still in draft, it serves just as a preview.
📚 Description
This is the MR for the following issues and disucssions:
📝 Checklist