Merge pull request framer#403 from framer/global-search/fix-stale-data

Global Search: remove items up to current indexer run

Author: elmarburke

plugins/global-search/src/components/DevToolsScene.tsx

@@ -149,6 +149,13 @@ export function DevToolsScene() {
                                         {selectedEntry.rootNodeName} ({selectedEntry.rootNodeType})
                                     </p>
                                 </div>
+
+                                <div>
+                                    <label className="block text-xs font-medium text-gray-700 mb-1">Indexer Run</label>
+                                    <pre className="text-sm bg-gray-50 p-2 rounded whitespace-pre-wrap">
+                                        {selectedEntry.addedInIndexRun}
+                                    </pre>
+                                </div>
                             </div>
                         </div>
                     ) : (

plugins/global-search/src/utils/db.ts

@@ -50,7 +50,8 @@ export class GlobalSearchDatabase implements ResumableAsyncIterable<IndexEntry>
         const tx = db.transaction("entries", "readonly")
         const store = tx.objectStore("entries")
 
-        const keyRange = startKey ? IDBKeyRange.lowerBound(startKey) : undefined
+        // Use exclusive lower bound (true) to avoid re-processing the startKey item when resuming
+        const keyRange = startKey ? IDBKeyRange.lowerBound(startKey, true) : undefined
         let cursor = await store.openCursor(keyRange)
 
         try {

plugins/global-search/src/utils/indexer/indexer.ts

@@ -1,6 +1,6 @@
 import {
     type AnyNode,
-    Collection,
+    type Collection,
     framer,
     isComponentNode,
     isFrameNode,
@@ -198,7 +198,7 @@ export class GlobalSearchIndexer {
             // this isn't a unnecassary static expression, as the value could change during the async loop
             // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
             if (!this.abortRequested) {
-                await this.db.clearEntriesFromBefore(lastIndexRun)
+                await this.db.clearEntriesFromBefore(currentIndexRun)
                 this.eventEmitter.emit("completed")
             }
         } catch (error) {