Skip to content

Commit fffe0e3

Browse files
Merge pull request framer#344 from framer/fix/required-pr-descriptions
PR descriptions should be required.
2 parents 96de9d4 + 5f8265f commit fffe0e3

2 files changed

Lines changed: 34 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ on:
44
push:
55
branches: [main]
66
pull_request:
7+
merge_group:
78

89
jobs:
910
yarn:

.github/workflows/shippy.yml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
name: Shippy
2+
3+
on:
4+
pull_request:
5+
types:
6+
- opened
7+
- edited
8+
- ready_for_review
9+
- synchronize
10+
workflow_dispatch:
11+
# NOTE: To prevent GitHub from adding PRs to the merge queue before check is done,
12+
# make sure that there is a ruleset that requires the “Shippy check to pass.
13+
merge_group:
14+
types:
15+
- checks_requested
16+
17+
concurrency:
18+
group: ${{ github.workflow }}-${{ github.ref }}
19+
cancel-in-progress: true
20+
21+
jobs:
22+
check-pr-description:
23+
name: PR Description Check
24+
runs-on: ubuntu-latest
25+
if: github.event.pull_request.draft == false && github.event.pull_request.user.login != 'dependabot[bot]'
26+
steps:
27+
- name: Check PR description
28+
run: |
29+
trimmed="$(echo "${{ github.event.pull_request.body }}" | xargs)"
30+
if [ -z "$trimmed" ]; then
31+
echo "❌ PR description is required."
32+
exit 1
33+
fi

0 commit comments

Comments
 (0)