Skip to content

Commit 3e4259b

Browse files
committed
fix(release): match create-dmg output Programa*.dmg (case-sensitive runner)
The v0.1.0 release built, signed, and notarized the app successfully but failed at `mv ./programa*.dmg`: create-dmg (npm) names the DMG after the app bundle ("Programa 0.1.0.dmg"), and GitHub's macOS runner filesystem is case-sensitive, so the lowercase glob (ported from upstream's cmux*.dmg) matched nothing.
1 parent 89c552c commit 3e4259b

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,10 @@ jobs:
323323
--identity="$APPLE_SIGNING_IDENTITY" \
324324
"$APP_PATH" \
325325
./
326-
mv ./programa*.dmg "$DMG_RELEASE"
326+
# create-dmg (npm) names the DMG after the app bundle, e.g. "Programa 0.1.0.dmg".
327+
# GitHub macOS runners use a case-sensitive filesystem, so the glob must match
328+
# the capitalized product name exactly.
329+
mv ./Programa*.dmg "$DMG_RELEASE"
327330
DMG_SUBMIT_JSON="$(xcrun notarytool submit "$DMG_RELEASE" --apple-id "$APPLE_ID" --team-id "$APPLE_TEAM_ID" --password "$APPLE_APP_SPECIFIC_PASSWORD" --wait --output-format json)"
328331
DMG_SUBMIT_ID="$(python3 -c 'import json,sys; print(json.load(sys.stdin)["id"])' <<<"$DMG_SUBMIT_JSON")"
329332
DMG_STATUS="$(python3 -c 'import json,sys; print(json.load(sys.stdin)["status"])' <<<"$DMG_SUBMIT_JSON")"

0 commit comments

Comments
 (0)