fix: CI smoke test speaks v2 JSON-RPC#77
Merged
Merged
Conversation
The macOS Compatibility smoke test still sent raw v1 lines (ping, send) and failed on main after the v1 protocol removal (#75) with a v1_removed error — the one consumer the migration inventory missed because it greps workflows for test paths, not inline socket writes. Ported to system.ping and surface.send_text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Unbreaks the
macOS Compatibilityworkflow on main: its smoke test still pinged the socket with raw v1 lines and started failing after the v1 protocol removal (#75). Now usessystem.pingandsurface.send_text.Summary
scripts/smoke-test-ci.shported from v1 text to v2 JSON frames; assertions adapted to the v2 response envelopeTest Plan