make gui_update a default function

Author: zisoft

src/libs/filtering.c

@@ -2250,12 +2250,6 @@ void gui_init(dt_lib_module_t *self)
   DT_CONTROL_SIGNAL_HANDLE(DT_SIGNAL_IMAGES_ORDER_CHANGE, _dt_images_order_change);
 }
 
-void gui_update(dt_lib_module_t *self)
-{
-  // Don't remove the empty function to not break the gui_update chain.
-  // It is needed to update the preset_label in the module header when params change.
-}
-
 void gui_cleanup(dt_lib_module_t *self)
 {
   dt_lib_filtering_t *d = self->data;

src/libs/import.c

@@ -2502,12 +2502,6 @@ void gui_init(dt_lib_module_t *self)
   dt_gui_update_collapsible_section(&d->cs);
 }
 
-void gui_update(dt_lib_module_t *self)
-{
-  // Don't remove the empty function to not break the gui_update chain.
-  // It is needed to update the preset_label in the module header when params change.
-}
-
 void gui_cleanup(dt_lib_module_t *self)
 {
   dt_lib_import_t *d = self->data;

src/libs/lib.c

@@ -661,6 +661,11 @@ static gboolean default_preset_autoapply(dt_lib_module_t *self)
   return FALSE;
 }
 
+/* default gui_update implementation */
+static void default_gui_update(dt_lib_module_t *self)
+{
+}
+
 static int dt_lib_load_module(void *m,
                               const char *libname,
                               const char *module_name)
@@ -879,7 +884,7 @@ void dt_lib_gui_queue_update(dt_lib_module_t *module)
 
 void dt_lib_gui_update(dt_lib_module_t *module)
 {
-  if(module && module->gui_update && !module->gui_uptodate)
+  if(module && !module->gui_uptodate)
   {
     module->gui_update(module);
     module->gui_uptodate = TRUE;
@@ -906,9 +911,8 @@ static void dt_lib_init_module(void *m)
     if(module->widget)
     {
       g_object_ref_sink(module->widget);
-      if(module->gui_update)
-        g_signal_connect(G_OBJECT(module->widget), "draw",
-                         G_CALLBACK(_lib_draw_callback), module);
+      g_signal_connect(G_OBJECT(module->widget), "draw",
+                       G_CALLBACK(_lib_draw_callback), module);
     }
   }
 }

src/libs/lib_api.h

@@ -64,7 +64,7 @@ OPTIONAL(void, gui_reset, struct dt_lib_module_t *self);
 /** update libs gui when visible
     triggered by dt_lib_gui_queue_update.
     don't use for widgets accessible via actions when hidden. */
-OPTIONAL(void, gui_update, struct dt_lib_module_t *self);
+DEFAULT(void, gui_update, struct dt_lib_module_t *self);
 
 OPTIONAL(GtkWidget *, gui_tool_box, struct dt_lib_module_t *self);