Filtered darkroom browsing broken

[jsmucr]

Is there an existing issue for this?

• I checked and did not find my issue in the already reported ones

Describe the bug

Darkroom navigation can break when browsing images with a filter turned on. Should the current image get ruled out by a user action (e.g. rejected), the next image is not the one following the removed image but the very first image in the filtered collection.

Steps to reproduce

1. Start with an empty data dir to rule out your own UI settings.
2. Import at least 3 images into a new collection.
3. Right-click the star filter and select all except rejected.
4. Double-click the first image. Darkroom opens.
5. (Press Ctrl+Shift+B twice to better appreciate the level of confusion coming. Personally, I keep the filmstrip hidden.)
6. Press Space to move on to the next image.
7. Press R to mark that image as rejected.
8. Press Space to move on to the third image.
9. Nope. You're back to the first image.

This is especially painful with more than a small amount of images.

Expected behavior

darktable should move on to the next image

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

darktable.org / GitHub release

darktable version

5.5.0+1106~3b42f13

What OS are you using?

Windows

What is the version of your OS?

10 Pro

Describe your system

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

[wpferguson]

I can reproduce on Linux, but not consistently. If I try it within the first few images, it works correctly advancing to the next image. If I'm 20+ images into an editing session then it occurs. I'm editing images that are rated 1 star, so when I open one and don't want it I just rate it 0 stars.

[jsmucr]

Broken by #20586.

[TurboGit]

@masterpiga : Can you have a look? TIA.

[masterpiga]

@TurboGit I was looking, but it appears that @jsmucr has a fix already.

[wpferguson]

@masterpiga I'm concerned that @jsmucr is adding a fix on top of the change, and not looking at the change and correcting the original problem. I don't think we want to get into a cycle of adding fixes to fixes.

[jsmucr]

It was always a bit broken, but particularly when rejecting using the filmstrip. This was new.
I'm the last one to fancy patching patches but the only other way around I can see would be huge refactoring of how collection navigation is dealt with in general.

[masterpiga]

Please take a look at #20906.