Touchpad: allow simultaneous smartphone-like pinch zoom and pan gestures in darkroom#20812
Open
da-phil wants to merge 5 commits intodarktable-org:masterfrom
Open
Touchpad: allow simultaneous smartphone-like pinch zoom and pan gestures in darkroom#20812da-phil wants to merge 5 commits intodarktable-org:masterfrom
da-phil wants to merge 5 commits intodarktable-org:masterfrom
Conversation
Collaborator
|
Contributor
Author
Maybe that was meant as a reply to my comment in the other PR, with the additional input touchpad logging output: |
Collaborator
|
Works fine on macOS: pan_zoom.mp4But current master is already working the same, so no difference :)
Nothing else in the log |
Contributor
Author
Cool! As stated above, the additional diagnosis logging output was provided in the other PR which is supposed to generally address issue with touchpad gestures. Does seamless / combined zooming and panning work as well for you? Like a combined zooming & panning gesture, which also works on smartphones? |
Collaborator
|
I can either zoom or pan with two fingers. Starting a zoom and then pan in the same gesture does not work. But as I already wrote above: This also works on current master without this PR. |
Contributor
Author
Yes, the same for me on Ubuntu 24.04 when running master, however this PR should allow seamless / combined panning & zooming. |
Contributor
Author
|
@zisoft I pushed two commits which added some logging statements to diagnose why it is not working on macOS, and even a potential fix. This is how it looks for me when zooming in: and for zooming out: |
Collaborator
|
zoom in: zoom out: combined zoom and pan still does not work. |
Contributor
Author
|
Thanks for providing the log msgs, this was helpful. Can you try again with the latest changes please and provide logs if it still doesn't work? |
Collaborator
|
Unfortunately no change. I start with pinch to zoom and then pan. Only zoom is recognized: |
Contributor
Author
|
Thank you for the logs again. I'm not sure why it still doesn't work. I added more logging that will hopefully reveal what's actually reaching Can you please run the latest changes and provide logs for the following scenarios:
Thanks! |
Collaborator
|
Ok, lots of output coming...
|
Collaborator
|
The other way (start with pan and then zoom) is also not recognized, it keeps panning. |
Contributor
Author
|
Phew, it seems that the macOS quartz GTK backend works completely different than for Windows & Linux, E.g. on my Linux laptop I receive pinch events which simultaneous updates to After feeding the data to copilot for analysis, this is the final verdict, which is also quite obvious from looking at the data:
I don't think I'll continue going down this path for this PR as I do not have access to a MacBook for testing, sorry :/ Maybe a follow-up question: do you know another open-source GTK based software which allows this kind of smartphone-like combined zoom + pan touchpad gestures? |
da-phil
changed the title
Collaborator
Inkscape is also a GTK3 application and it shows the exact same behavior: You either pinch or pan on macOS, not simultaneously. |
Contributor
Author
Hmmm, another indicator that it seems it's not possible with the macOS quartz GTK backend :/ |
da-phil
force-pushed
the
touchpad_seamless_pinch_zoom_and_pan
branch
from
b26418c to
3ee6473
Compare
Contributor
Author
|
@zisoft last question: does the current state of the PR is cause any touchpad behavior regressions on macOS for you? @ All other users and contributors running Windows & Linux: please give this PR a try and provide some feedback if it works for you. |
Collaborator
besides the already discussed simultaneously panning/zooming: No, everything works as expected. |
Contributor
Author
As far as remember, he said that this feature doesn't even work on master currently. The scope of this PR is just allowing simultaneous pitch and pannig gestures within darkroom. |
The macOS built-in trackpad reports as GDK_SOURCE_MOUSE (not GDK_SOURCE_TOUCHPAD). The _scrolled routing condition required either GDK_SOURCE_TOUCHPAD or a device previously seen in a pinch event (_touchpad). On macOS, neither condition held before a pinch had been seen, so two-finger scroll events fell through to dt_view_manager_scrolled (image navigation) instead of gesture_pan (panning). A #ifdef GDK_WINDOWING_QUARTZ branch now routes all non-ctrl smooth scrolls to gesture_pan on macOS. Net result: On macOS, zoom via pinch works (was already working), and pan via two-finger swipe now works via gesture_pan. Combined pinch+pan simultaneously is not possible at the GDK level on macOS — NSEventTypeMagnify does not deliver the translational component; it must be done as sequential operations (zoom then pan).
da-phil
force-pushed
the
touchpad_seamless_pinch_zoom_and_pan
branch
from
3ee6473 to
1d647fb
Compare
da-phil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses points (d) of issue #20750.
With this change gesture based pinch zooming and panning is seamless and keeps pinch fully continuous for a smartphone-like feeling, including at high zoom levels.
Screencast.from.2026-04-14.11-47-04.mp4
CC @zisoft @MStraeten: I would appreciate feedback on how this feels on MacOS.
Disclaimer: co-created with copilot.