Skip to content

rotate and perspective: scrolling up/down should increase/decrease selection circle diameter#20833

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
kofa73:rotate-and-perspective-scroll-up-to-increase-selection-circle
Apr 20, 2026
Merged

rotate and perspective: scrolling up/down should increase/decrease selection circle diameter#20833
TurboGit merged 1 commit into
darktable-org:masterfrom
kofa73:rotate-and-perspective-scroll-up-to-increase-selection-circle

Conversation

@kofa73

@kofa73 kofa73 commented Apr 19, 2026

Copy link
Copy Markdown
Collaborator

When editing drawn masks, scrolling up / down increases / decreases the size of the selection circle, the drawn mask, or feathering. In rotate and perspective, it works the other way around. The current PR applies the same behaviour as used in masks, up means increase, down means decrease.

…lection circle diameter, not the other way around
@TurboGit TurboGit added this to the 5.6 milestone Apr 20, 2026
@TurboGit TurboGit added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: image processing correcting pixels release notes: pending labels Apr 20, 2026

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
TurboGit merged commit 38d048c into darktable-org:master Apr 20, 2026
5 checks passed
@kofa73
kofa73 deleted the rotate-and-perspective-scroll-up-to-increase-selection-circle branch April 20, 2026 19:08
@kofa73

kofa73 commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks @TurboGit , but there's more to clean up, see #20832 (comment). We'll have to discuss this and come up with a plan.

An added complication is that some enable a "natural scroll" setting, which reverses scroll direction, which they'll probably want to keep for scroll bars, but still use scroll up / down = increase / decrease size (e.g. selection circles) or value (sliders).

@TurboGit

Copy link
Copy Markdown
Member

Thanks @TurboGit , but there's more to clean up, see #20832 (comment). We'll have to discuss this and come up with a plan.

Yes, saw that.

@TurboGit

TurboGit commented Jun 8, 2026

Copy link
Copy Markdown
Member

@kofa73
We need a release note entry for 5.6. Also please check other closed PR if needed. TIA.

@kofa73

kofa73 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

Fixed scroll direction in rotate and perspective module: scrolling up/down now increases/decreases the selection circle size, matching how resizing drawn masks works.

@TurboGit

TurboGit commented Jun 9, 2026

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: image processing correcting pixels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants