RFC: Some build requirement updates#21329
Draft
jenshannoschwalm wants to merge 1 commit into
Draft
Conversation
jenshannoschwalm
added
the
scope: codebase
ralfbrown
reviewed
Jun 16, 2026
| dt_omp_firstprivate(original_4ch, denoised_4ch, \ | ||
| lum_residual, npix) \ | ||
| schedule(simd:static) \ | ||
| aligned(original_4ch, denoised_4ch, lum_residual:64) |
Collaborator
There was a problem hiding this comment.
It would make sense to convert this and the pragma below to using one of the DT_OMP_FOR macro variants, whether or not the _OPENMP removal takes place.
Collaborator
There was a problem hiding this comment.
Agree. I think DT_OMP_FOR_SIMD makes sense here. Want me to make it is a separate PR? Or you cann just fix it here
DT_OMP_FOR_SIMD(aligned(original_4ch, denoised_4ch, lum_residual:64))
for(size_t i = 0; i < npix; i++)
{
...
}
014481b to
1d26246
Compare
Collaborator
Author
|
The homebrew CI needs some additional omp.h "include" ? Don't know if it build on a mac-at-home. So "draft" for now. |
| dt_omp_firstprivate(original_4ch, denoised_4ch, \ | ||
| lum_residual, npix) \ | ||
| schedule(simd:static) \ | ||
| aligned(original_4ch, denoised_4ch, lum_residual:64) |
Collaborator
There was a problem hiding this comment.
Agree. I think DT_OMP_FOR_SIMD makes sense here. Want me to make it is a separate PR? Or you cann just fix it here
DT_OMP_FOR_SIMD(aligned(original_4ch, denoised_4ch, lum_residual:64))
for(size_t i = 0; i < npix; i++)
{
...
}
1d26246 to
e1718f3
Compare
1. Make OpenMP a build requirement as non-OpenMP builds - don't help for anything - add code burden that would require special testing - don't have acceptable performance External code like rawspeed and libraw are not touched. 2. With current compilers we can assume proper vectorizing support so the DT_NO_VECTORIZATION and DT_NO_SIMD_HINTS can be removed. 3. As OpenMP and SSE2 are no build options, don't show them in the log file.
jenshannoschwalm
force-pushed
the
required_openmp
branch
from
e1718f3 to
cce1e27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make OpenMP a build requirement as non-OpenMP builds
With current compilers we can assume proper vectorizing support so the DT_NO_VECTORIZATION and DT_NO_SIMD_HINTS can be removed.
As OpenMP and SSE2 are no build options, don't show them in the log file.
@ralfbrown your ideas on this?