Port gamepad from SDL2 to SDL3#21379
Draft
rtmongold wants to merge 1 commit into
Draft
Conversation
rtmongold
force-pushed
the
gamepad_port_sdl3
branch
from
ec17be9 to
f86c13a
Compare
I know this is a bit late, but wanted to get it out here for review while I continue testing. Following the SDL3 migration: https://wiki.libsdl.org/SDL3/README-migration Renamed SDL2 game controller API to SDL3 gamepad equivalents. Button names have changed but kept a/b/x/y shortcut names and aliased south/east/west/north. Updated build, CI, and packaging to depend on SDL3. Removed the libSDL3 copy from macOS packaging script.
rtmongold
force-pushed
the
gamepad_port_sdl3
branch
from
ee2444d to
19e5f7a
Compare
| librsvg2-dev \ | ||
| libsaxon-java \ | ||
| libsdl2-dev \ | ||
| libsdl3-dev \ |
Collaborator
There was a problem hiding this comment.
The nightly build will fail here because neither the Ubuntu 22.04 runner (on which we build the x86_64 AppImage) nor the Ubuntu 24.04 runner (on which we build the aarch64 AppImage) have libsdl3.
Contributor
Author
There was a problem hiding this comment.
What about removing this line and doing something like FindONNXRuntime.cmake, check system pkg -> prev built pkg -> last resort vendor a minimal SDL3?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21374
Following the SDL3 migration:
https://wiki.libsdl.org/SDL3/README-migration
Renamed SDL2 game controller API to SDL3 gamepad equivalents.
Button names have changed but kept a/b/x/y shortcut names and aliased south/east/west/north.
Updated build, CI, and packaging to depend on SDL3.
Removed the libSDL3 copy from macOS packaging script.