Add vectorize button to external raster masks doc#833
Conversation
|
This pull request has not had any activity in the past 60 days and will be closed in 365 days if not updated. Please verify it has no conflicts with the master branch and rebase if needed. Please add a comment if you need help or give permission to other people to finish your work. |
|
@anoderay I'm not sure why you assigned this to me. |
|
@anoderay : Maybe for a final quick review (check that only needed files are in the PR) and merged. I have asked for the final merge to be done by another contributor if possible (except for quick typos). But that's only my proposal, you can of course agree on a workflow for all contributors to the doc. |
You are correct, that didn't make sense. Did you see my comment? |
I don't see any comments. If you started a review, you need to submit the review before I see the comments. |
|
|
||
| file selection | ||
| : Choose the external raster file to use. File selection is inactive if the rasterfile root folder has not been defined in [preferences > processing](../../preferences-settings/processing.md). | ||
| : Choose the external raster file to use. File selection is inactive if the raster mask files root folder has not been defined in [preferences > processing](../../preferences-settings/processing.md). |
There was a problem hiding this comment.
I would suggest replacing "inactive" with "might be unavailable". I am also not even sure it is true. I set the raster mask folder to blank in darktablerc to try this out and could still load a raster mask without issue.
There was a problem hiding this comment.
I've pushed an update. Do you think that is better?
There was a problem hiding this comment.
I would suggest replacing "inactive" with "might be unavailable"
Please don't do this! I suggest adding the word "might" to the blacklist of words that are prohibited in the user guide. "Might" is a word used as a modal verb to express possibility or uncertainty, often suggesting a lower likelihood than "may".
I am also not even sure it is true. I set the raster mask folder to blank in darktablerc to try this out and could still load a raster mask without issue.
Yes, you're right. I assume that this description was copied from the description of a similar control element of the LUT3D module. But since then, changes have been made and the LUT3D root directory in the preferences now has a default value (i.e. it simply cannot be undefined), as a result the description of "file selection" in the LUT3D module became inaccurate (it also needs to be corrected). The external raster masks module has a similar implementation, its root folder always has some definition and the control cannot be inactive.
There was a problem hiding this comment.
Thank you for this important note @victoryforce . @Phemisters I think the wording from your latest update is fine.
4 participants
Relates to this darktable PR: darktable-org/darktable#20198
Add the new vectorize button to the external raster masks module documentation. This allows users to generate path masks from raster mask files.
For experimenting, I used the PFM file linked to in one of the PR comments.
I also noticed that the text for a preference related to external raster masks was incorrect, so I updated it to match the current preferences text.