Watermark: add note about effect of framing on position#842
Open
deekayhd wants to merge 1 commit intodarktable-org:masterfrom
Open
Watermark: add note about effect of framing on position#842deekayhd wants to merge 1 commit intodarktable-org:masterfrom
deekayhd wants to merge 1 commit intodarktable-org:masterfrom
Conversation
Phemisters
reviewed
May 8, 2026
|
|
||
| --- | ||
|
|
||
| **Note**: When using the watermark in combination with the framing module, keep in mind that the added frame affects the watermark’s position. For example, if you align the watermark to an edge, it may appear within the frame instead of on the actual image. To ensure the watermark is positioned relative to the image itself, you can manually adjust the module order so that the framing module comes after the watermark module in the pixelpipe. |
Collaborator
There was a problem hiding this comment.
This looks good. I have a couple of suggestions for you to consider:
- maybe replace
keep in mind that the added framewiththe added frame, as I guess that will be easier for translations. - adjusting the module order is maybe not that common, so maybe link to it with something like
manually [adjust the module order](../../../darkroom/pixelpipe/the-pixelpipe-and-module-order.md) so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal for issue #724.
I added a note to the documentation of the watermark module that the framing module affects the positioning of the watermark and that this can be solved by changing the default order of the modules manually.
closes #724