Skip to content

fix: skip node_modules in updater markdown and shell scans#309

Open
zhao0112 wants to merge 1 commit intodarrenhinde:mainfrom
zhao0112:fix/update-script-exclude-node_modules
Open

fix: skip node_modules in updater markdown and shell scans#309
zhao0112 wants to merge 1 commit intodarrenhinde:mainfrom
zhao0112:fix/update-script-exclude-node_modules

Conversation

@zhao0112
Copy link
Copy Markdown

@zhao0112 zhao0112 commented Apr 22, 2026

Summary

Changes

  • Add -not -path "*/node_modules/*" to the find loop for *.md files.
  • Add -not -path "*/node_modules/*" to the find loop for *.sh files.

Testing

  • bash -n update.sh
  • Fixture test: created a synthetic .opencode install dir with files under normal/ and node_modules/; verified updater only attempts non-node_modules files.
  • npm test -- --passWithNoTests (local environment: missing tsx)
  • cd evals/framework && npm test -- --passWithNoTests (local environment: missing vitest)
  • ruff check . (reports existing baseline errors in scripts/registry/fix-registry.py, pre-existing)

Verification

  • Independent pre-flight review (requesting-code-review equivalent) returned:
    • passed: true
    • no security concerns
    • no logic errors

Closes #308

MomePP added a commit to MomePP/OpenAgentsControl that referenced this pull request Apr 28, 2026
User-facing changes since 1.0.3:
- fix(context-scout): empty-state response when no context bundle is
  installed (cherry-pick of upstream issue darrenhinde#310 spirit)
- refactor: agent permissions allow `question` tool (upstream PR darrenhinde#302)
- fix: update.sh skips node_modules in markdown and shell scans
  (upstream PR darrenhinde#309)

Sync marketplace.json plugin entry to match plugin.json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: update.sh tries to update node_modules READMEs (lines 245, 263)

1 participant