Italian language update#448
Open
bovirus wants to merge 3 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAggiornate cinque aree di localizzazione italiana in WhatCable e WhatCableCore, includendo messaggi di aggiornamento, consenso diagnostico, compatibilità Intel e stati Thunderbolt. ChangesLocalizzazione italiana
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Sources/WhatCable/Resources/it.lproj/Localizable.strings`:
- Around line 175-176: Correct the Italian translation in the Intel notice
string by changing “dati edi cavi” to “dati dei cavi” and removing the space
before the comma in “aperta ,”, yielding “aperta,”.
- Line 103: Update the Italian translation for the hardware UUID privacy
disclosure so it explicitly states that hashing with SHA-256 occurs before
sending by adding “prima dell’invio” after “SHA-256”; preserve the rest of the
translated disclosure unchanged.
- Line 99: Update the Italian translation value for the Raw IOKit description in
Localizable.strings, changing “Proprietà registro Raw IOKit” to the
grammatically correct “Proprietà del registro Raw IOKit” while preserving the
rest of the translation.
In `@Sources/WhatCableCore/Resources/it.lproj/Localizable.strings`:
- Line 561: Update the Italian translation for “Shared controller port” in the
Localizable.strings entry to “Porta condivisa del controller”, preserving the
existing key and string format.
- Line 488: Update the Italian localization value for the “adapter %lld” key
from “scheda %lld” to “adattatore %lld”, preserving the placeholder exactly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 2dff4b78-0316-46c1-b9f4-0557d388283f
📒 Files selected for processing (2)
Sources/WhatCable/Resources/it.lproj/Localizable.stringsSources/WhatCableCore/Resources/it.lproj/Localizable.strings
Comment on lines
+175
to
+176
| "WhatCable can't read cables on this Mac" = "In questo Mac WhatCable non può leggere le info sui cavi"; | ||
| "This Mac has an Intel processor. WhatCable gets its cable and port data from Apple Silicon's port controller, and Intel Macs don't expose it, so the app will show nothing useful.\n\nIt'll stay open if you want to look around, but there's nothing behind it." = "Questo Mac ha un processore Intel. WhatCable ricava i dati edi cavi e porte dal controller porte Apple Silicon, che i Mac Intel non espongono, quindi l'app non visualizzerà nulla di utile.\n\nSe vuoi dare un'occhiata resterà aperta , ma dietro non c'è nulla."; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Fix the Intel notice typo and punctuation.
Line 176 contains “dati edi cavi” and an extra space before the comma in “aperta ,”. At minimum, change these to “dati dei cavi” and “aperta,”.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Sources/WhatCable/Resources/it.lproj/Localizable.strings` around lines 175 -
176, Correct the Italian translation in the Intel notice string by changing
“dati edi cavi” to “dati dei cavi” and removing the space before the comma in
“aperta ,”, yielding “aperta,”.
Contributor
Author
|
Now all should be ok. |
Contributor
Author
|
If is ok, could you please merge? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@darrylmorley
Please merge. Thanks.
Summary by CodeRabbit