fix: rename ready-to-merge to status: ready-to-merge

Addresses maintainer feedback to match the original MVP proposal naming
convention. Also updates the label description to accurately reflect the
new logic requirement of '1+ maintainer and 2+ total approvals' instead
of the old description.

Signed-off-by: darshit2308 <darshit2308@gmail.com>

Author: darshit2308

.github/scripts/review-sync/helpers/constants.js

@@ -33,9 +33,9 @@ const QUEUE_LABELS = {
     description: 'PR awaiting maintainer final review',
   },
   MERGE: {
-    name: 'ready-to-merge',
+    name: 'status: ready-to-merge',
     color: '0e8a16',
-    description: 'PR approved by maintainer and ready to merge',
+    description: 'PR has 1+ maintainer and 2+ total approvals, ready to merge',
   },
 };
 

.github/scripts/review-sync/helpers/labels.js

@@ -57,14 +57,14 @@ async function ensureLabel(github, owner, repo, label, dryRun) {
  * Determine the correct queue label for a PR based on approval counts.
  *
  * Phase 1 logic (4-stage pipeline):
- *   maintainerApproval >= 1 AND anyApproval >= 2  → ready-to-merge      (CODEOWNERS + min reviews)
+ *   maintainerApproval >= 1 AND anyApproval >= 2  → status: ready-to-merge      (CODEOWNERS + min reviews)
  *   writeApproval >= 1 OR maintainerApproval >= 1 → queue:maintainers   (senior review present, needs more)
  *   anyApproval >= 1                               → queue:committers    (has any approval, needs committer)
  *   else                                           → queue:junior-committer (no approvals yet)
  *
- * Note: ready-to-merge requires BOTH a maintainer approval AND at least 2
+ * Note: status: ready-to-merge requires BOTH a maintainer approval AND at least 2
  * total reviews. This prevents a single maintainer approval from marking
- * a PR as ready-to-merge when branch protection requires 2+ reviews.
+ * a PR as status: ready-to-merge when branch protection requires 2+ reviews.
  *
  * @param {{ maintainerApproval: number, writeApproval: number, softApproval: number, anyApproval: number }} approvals
  * @returns {object} The correct QUEUE_LABELS entry

.github/scripts/review-sync/tests/test-labels.js

@@ -32,32 +32,32 @@ const unitTests = [
     },
   },
   {
-    name: 'determineLabel: 2 write + 0 maintainer → queue:maintainers (NOT ready-to-merge)',
+    name: 'determineLabel: 2 write + 0 maintainer → queue:maintainers (NOT status: ready-to-merge)',
     test: () => {
       const r = determineLabel({ maintainerApproval: 0, writeApproval: 2, softApproval: 0, anyApproval: 2 });
       return r.name === 'queue:maintainers';
     },
   },
   {
-    name: 'determineLabel: 1 maintainer alone → queue:maintainers (NOT ready-to-merge, needs 2 reviews)',
+    name: 'determineLabel: 1 maintainer alone → queue:maintainers (NOT status: ready-to-merge, needs 2 reviews)',
     test: () => {
       // Sophie's edge case: maintainer approves first, only 1 total review
       const r = determineLabel({ maintainerApproval: 1, writeApproval: 0, softApproval: 0, anyApproval: 1 });
       return r.name === 'queue:maintainers';
     },
   },
   {
-    name: 'determineLabel: 1 maintainer + 1 write → ready-to-merge (2 reviews satisfied)',
+    name: 'determineLabel: 1 maintainer + 1 write → status: ready-to-merge (2 reviews satisfied)',
     test: () => {
       const r = determineLabel({ maintainerApproval: 1, writeApproval: 1, softApproval: 0, anyApproval: 2 });
-      return r.name === 'ready-to-merge';
+      return r.name === 'status: ready-to-merge';
     },
   },
   {
-    name: 'determineLabel: 1 maintainer + 1 soft → ready-to-merge (2 reviews satisfied)',
+    name: 'determineLabel: 1 maintainer + 1 soft → status: ready-to-merge (2 reviews satisfied)',
     test: () => {
       const r = determineLabel({ maintainerApproval: 1, writeApproval: 0, softApproval: 1, anyApproval: 2 });
-      return r.name === 'ready-to-merge';
+      return r.name === 'status: ready-to-merge';
     },
   },
   {
@@ -121,7 +121,7 @@ const unitTests = [
         ],
       });
       const changed = await syncLabel(mock, 'o', 'r', { number: 1, labels: [{ name: 'queue:junior-committer' }] }, false);
-      return changed === true && mock.calls.labelsAdded.includes('ready-to-merge') && mock.calls.labelsRemoved.includes('queue:junior-committer');
+      return changed === true && mock.calls.labelsAdded.includes('status: ready-to-merge') && mock.calls.labelsRemoved.includes('queue:junior-committer');
     },
   },
   {