fix: Address some more issues

Signed-off-by: darshit2308 <darshit2308@gmail.com>

Author: darshit2308

.github/scripts/review-sync/helpers/labels.js

@@ -55,18 +55,36 @@ async function ensureLabel(github, owner, repo, label, dryRun) {
 
 /**
  * Check if the latest CI runs for a given commit have any failures.
- * Returns true if any check run conclusion is 'failure' or 'timed_out'.
+ * 
+ * We intentionally treat the following as failures:
+ * - 'failure', 'timed_out' (explicit test failures)
+ * - 'startup_failure' (e.g., invalid workflow YAML)
+ * - 'action_required' (e.g., waiting for maintainer approval for first-time contributors)
+ * 
+ * We intentionally EXCLUDE 'cancelled':
+ * When a developer pushes a new commit, GitHub automatically cancels the currently 
+ * running workflows. If we treated 'cancelled' as a failure, every re-push would 
+ * instantly demote the PR to queue:junior-committer, frustrating contributors.
+ * 
+ * @returns {boolean} true if any check run conclusion is a blocking failure.
  */
 async function hasCIFailures(github, owner, repo, sha) {
   try {
-    const { data } = await github.rest.checks.listForRef({
+    // We MUST use paginate, otherwise it silently truncates at 30 runs.
+    // Matrix builds often exceed 30 checks.
+    const checkRuns = await github.paginate(github.rest.checks.listForRef, {
       owner,
       repo,
       ref: sha,
       filter: 'latest'
     });
-    return data.check_runs.some(
-      run => run.conclusion === 'failure' || run.conclusion === 'timed_out'
+
+    return checkRuns.some(
+      run => 
+        run.conclusion === 'failure' || 
+        run.conclusion === 'timed_out' ||
+        run.conclusion === 'startup_failure' ||
+        run.conclusion === 'action_required'
     );
   } catch (error) {
     // Fail securely: do not assume CI is passing if we cannot verify it.

.github/scripts/review-sync/package.json

@@ -2,6 +2,7 @@
   "name": "review-sync",
   "version": "1.0.0",
   "description": "Automated PR review queue label sync scripts and tests",
+  "private": true,
   "main": "index.js",
   "scripts": {
     "test": "node tests/test-labels.js && node tests/test-permissions.js && node tests/test-reviews.js"

.github/scripts/review-sync/tests/test-labels.js

@@ -7,7 +7,7 @@
 
 const { runTestSuite, createMockGithub } = require('./test-utils');
 const { determineLabel, ensureLabel, syncLabel } = require('../helpers/labels');
-const { QUEUE_LABELS } = require('../helpers/constants');
+const { QUEUE_LABELS, COMMUNITY_REVIEW } = require('../helpers/constants');
 
 const unitTests = [
   {
@@ -167,7 +167,7 @@ const unitTests = [
       const mock = createMockGithub({ roles: {}, reviews: [] });
       const pr = { number: 1, labels: [{ name: 'queue:junior-committer' }], head: { sha: '123' }, user: { type: 'User' } };
       const changed = await syncLabel(mock, 'o', 'r', pr, false);
-      return changed === true && mock.calls.labelsAdded.includes('open to community review');
+      return changed === true && mock.calls.labelsAdded.includes(COMMUNITY_REVIEW.name);
     },
   },
 ];

.github/workflows/test-review-sync.yml

@@ -12,6 +12,7 @@ on:
 
 jobs:
   test:
+    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false
     runs-on: hl-sdk-py-lin-md
     permissions:
       contents: read