Skip to content

fix(dart_frog_cli): support workspace root pubspec_overrides.yaml#1897

Merged
felangel merged 4 commits into
mainfrom
fix/dart-frog-build-workspace-root-overrides
Oct 19, 2025
Merged

fix(dart_frog_cli): support workspace root pubspec_overrides.yaml#1897
felangel merged 4 commits into
mainfrom
fix/dart-frog-build-workspace-root-overrides

Conversation

@felangel

@felangel felangel commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

Status

READY

Description

  • fix(dart_frog_cli): support workspace root pubspec_overrides.yaml

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Oct 17, 2025
@felangel felangel added the bug Something isn't working as expected label Oct 17, 2025
erickzanardo
erickzanardo previously approved these changes Oct 17, 2025
@felangel

Copy link
Copy Markdown
Contributor Author

Planning to do some more testing over the weekend and if all looks good we can ship this fix on Monday

@felangel
felangel requested a review from erickzanardo October 17, 2025 20:15
marcossevilla
marcossevilla previously approved these changes Oct 18, 2025

@marcossevilla marcossevilla left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just a small typo


/// Add overrides for all path dependencies to `pubspec_overrides.yaml`
void overridePathDependenciesInPubspecOverrides({
/// Add overrides for all neccessary dependencies to `pubspec_overrides.yaml`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Add overrides for all neccessary dependencies to `pubspec_overrides.yaml`
/// Add overrides for all necessary dependencies to `pubspec_overrides.yaml`

@felangel
felangel merged commit 87bdb12 into main Oct 19, 2025
4 checks passed
@felangel
felangel deleted the fix/dart-frog-build-workspace-root-overrides branch October 19, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants