fix: spam filter fixtures , docs and tests

Author: mmanciop

.chloggen/fix-spam-filter-fixtures.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: bug_fix
+
+# The name of the component, or a single word describing the area of concern (e.g. dashboards, config, apply)
+component: spam-filters
+
+# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Fix spam filter FilterCriteria format in fixtures and tests to match the Dash0 API schema
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [134]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext: |
+  The filter criteria now use the correct flat format with `operator` and `value` fields instead of the nested `stringValue` format.
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with "chore" or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Default: '[user]'
+change_logs: []

internal/spamfilters/integration_test.go

@@ -273,10 +273,8 @@ spec:
     - log
   filter:
     - key: "k8s.namespace.name"
-      value:
-        stringValue:
-          operator: "equals"
-          comparisonValue: "kube-system"
+      operator: "is"
+      value: "kube-system"
 `), 0644)
 	require.NoError(t, err)
 
@@ -321,10 +319,8 @@ spec:
     - log
   filter:
     - key: "k8s.namespace.name"
-      value:
-        stringValue:
-          operator: "equals"
-          comparisonValue: "kube-system"
+      operator: "is"
+      value: "kube-system"
 `), 0644)
 	require.NoError(t, err)
 

internal/spamfilters/update_integration_test.go

@@ -37,10 +37,8 @@ spec:
     - log
   filter:
     - key: "k8s.namespace.name"
-      value:
-        stringValue:
-          operator: "equals"
-          comparisonValue: "kube-system"
+      operator: "is"
+      value: "kube-system"
 `), 0644)
 	require.NoError(t, err)
 
@@ -68,10 +66,8 @@ spec:
     - log
   filter:
     - key: "k8s.namespace.name"
-      value:
-        stringValue:
-          operator: "equals"
-          comparisonValue: "kube-system"
+      operator: "is"
+      value: "kube-system"
 `), 0644)
 	require.NoError(t, err)
 

internal/testutil/fixtures/spamfilters/create_success.json

@@ -17,12 +17,8 @@
     "filter": [
       {
         "key": "k8s.namespace.name",
-        "value": {
-          "stringValue": {
-            "operator": "equals",
-            "comparisonValue": "kube-system"
-          }
-        }
+        "operator": "is",
+        "value": "kube-system"
       }
     ]
   }

internal/testutil/fixtures/spamfilters/get_success.json

@@ -17,12 +17,8 @@
     "filter": [
       {
         "key": "k8s.namespace.name",
-        "value": {
-          "stringValue": {
-            "operator": "equals",
-            "comparisonValue": "kube-system"
-          }
-        }
+        "operator": "is",
+        "value": "kube-system"
       }
     ]
   }

internal/testutil/fixtures/spamfilters/list_success.json

@@ -19,12 +19,8 @@
         "filter": [
           {
             "key": "k8s.namespace.name",
-            "value": {
-              "stringValue": {
-                "operator": "equals",
-                "comparisonValue": "kube-system"
-              }
-            }
+            "operator": "is",
+            "value": "kube-system"
           }
         ]
       }
@@ -48,12 +44,8 @@
         "filter": [
           {
             "key": "otel.span.name",
-            "value": {
-              "stringValue": {
-                "operator": "starts_with",
-                "comparisonValue": "debug-"
-              }
-            }
+            "operator": "starts_with",
+            "value": "debug-"
           }
         ]
       }

test/roundtrip/fixtures/spam-filter.yaml

@@ -8,7 +8,5 @@ spec:
     - log
   filter:
     - key: "k8s.namespace.name"
-      value:
-        stringValue:
-          operator: "equals"
-          comparisonValue: "kube-system"
+      operator: "is"
+      value: "kube-system"