Skip to content

chore: create sanity checks for post release#51

Merged
mosheshaham-dash0 merged 4 commits into
masterfrom
clo-485-create-sanity-checks-for-post-release
Apr 16, 2026
Merged

chore: create sanity checks for post release#51
mosheshaham-dash0 merged 4 commits into
masterfrom
clo-485-create-sanity-checks-for-post-release

Conversation

@mosheshaham-dash0

Copy link
Copy Markdown
Collaborator

No description provided.

@linear-code

linear-code Bot commented Apr 16, 2026

Copy link
Copy Markdown

@GuyMoses GuyMoses left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. Version pinningresolve-layers picks the latest version via list-layer-versions, but there's a race condition: if another deploy lands between deploy-prod and this job, we could end up testing the wrong version. Better to pass the exact version from deploy-prod as an output so we know for sure we're testing what we just released.

  2. Failure notifications — right now failures only show up in the Actions tab. Especially with the daily cron, we should have a Slack notification (or similar) on failure so we actually hear about it.

@mosheshaham-dash0

Copy link
Copy Markdown
Collaborator Author

Two things:

  1. Version pinningresolve-layers picks the latest version via list-layer-versions, but there's a race condition: if another deploy lands between deploy-prod and this job, we could end up testing the wrong version. Better to pass the exact version from deploy-prod as an output so we know for sure we're testing what we just released.
  2. Failure notifications — right now failures only show up in the Actions tab. Especially with the daily cron, we should have a Slack notification (or similar) on failure so we actually hear about it.
  1. not sure it's needed. sounds like a very rare case. actually, very tight releases will cause a more serious problem anyway - overrides in the stack create/destroy since we currently have only one global stack. for now i think it's good enough.
  2. i've been meaning to add slack notification for all workflow failures and releases. will do so in a different PR

@mosheshaham-dash0 mosheshaham-dash0 merged commit 887e2f1 into master Apr 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants