mix.exs: Make it possible to build NIF from source.#38
Open
fishinthecalculator wants to merge 1 commit into
Open
mix.exs: Make it possible to build NIF from source.#38fishinthecalculator wants to merge 1 commit into
fishinthecalculator wants to merge 1 commit into
Conversation
Builds running in segregated environments, like Nix or Guix ones, have no access to the internet. Make it possible to build the NIF from source by setting the LAZY_HTML_BUILD=true environment variable. * mix.exs: Read LAZY_HTML_BUILD to make it possible to build the NIF from source instead of downloading its binary.
Member
|
Shall we just merge this with #37 and make it so the system configuration automatically implies building from source? |
| make_precompiler: {:nif, CCPrecompiler}, | ||
| make_precompiler_url: "#{@github_url}/releases/download/v#{@version}/@{artefact_filename}", | ||
| make_precompiler_filename: "liblazy_html", | ||
| make_precompiler_nif_versions: [versions: ["2.16"]], |
Member
There was a problem hiding this comment.
There is a config option to force the build, so we can add this instead:
make_force_build: System.get_env("LAZY_HTML_BUILD") in ["1", "true"],
Member
Sounds good! Though I wonder if instead of supporting system lexbor, we should vendor in the lexbor C code and still build it as usual. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds running in segregated environments, like Nix or Guix ones, have no access to the internet. Make it possible to build the NIF from source by setting the LAZY_HTML_BUILD=true environment variable.