fix: Fix failing PR tests in GitHub Actions

The PR tests were failing in CI because the mock gh executable path wasn't
being passed to the subprocess. Tests modified PATH with env::set_var() but
this only affected the current process, not subprocesses spawned by assert_cmd.

Changes:
- Add run_test_bin_with_env() helper to pass environment variables to subprocesses
- Update all PR tests that use mock gh to pass PATH explicitly
- Remove unnecessary env::set_var() and env::restore() calls

This fixes the test_list_command_with_pr_flag failure that was causing
CI to fail on the master branch after PR #45.

Author: dashed

tests/common/mod.rs

@@ -229,6 +229,33 @@ where
         .expect("Failed to run git-chain")
 }
 
+pub fn run_test_bin_with_env<I, T, E, K, V, P: AsRef<Path>>(
+    current_dir: P,
+    arguments: I,
+    env_vars: E,
+) -> Output
+where
+    I: IntoIterator<Item = T>,
+    T: AsRef<OsStr>,
+    E: IntoIterator<Item = (K, V)>,
+    K: AsRef<OsStr>,
+    V: AsRef<OsStr>,
+{
+    let mut current_dir_buf: PathBuf = current_dir.as_ref().into();
+    if current_dir_buf.is_relative() {
+        current_dir_buf = current_dir_buf.canonicalize().unwrap();
+    }
+
+    let mut cmd =
+        assert_cmd::Command::cargo_bin(env!("CARGO_PKG_NAME")).expect("Failed to get git-chain");
+
+    cmd.current_dir(current_dir_buf)
+        .args(arguments)
+        .envs(env_vars);
+
+    cmd.output().expect("Failed to run git-chain")
+}
+
 #[allow(dead_code)]
 pub fn run_test_bin_expect_err<I, T, P: AsRef<Path>>(current_dir: P, arguments: I) -> Output
 where

tests/pr.rs

@@ -183,13 +183,8 @@ fn test_pr_command_creates_prs_for_chain() {
     let absolute_mock_dir = mock_dir.canonicalize().unwrap();
     let new_path = format!("{}:{}", absolute_mock_dir.display(), original_path);
 
-    env::set_var("PATH", new_path);
-
-    // Run pr command
-    let output = run_test_bin(path_to_repo, ["pr"]);
-
-    // Restore original PATH
-    env::set_var("PATH", original_path);
+    // Run pr command with modified PATH
+    let output = run_test_bin_with_env(path_to_repo, ["pr"], vec![("PATH", new_path)]);
 
     let stdout = String::from_utf8_lossy(&output.stdout);
     let stderr = String::from_utf8_lossy(&output.stderr);
@@ -321,13 +316,9 @@ fn test_pr_command_with_draft_flag() {
     let original_path = env::var("PATH").unwrap_or_default();
     let absolute_mock_dir = mock_dir.canonicalize().unwrap();
     let new_path = format!("{}:{}", absolute_mock_dir.display(), original_path);
-    env::set_var("PATH", new_path);
 
-    // Run pr command with draft flag
-    let output = run_test_bin(path_to_repo, ["pr", "--draft"]);
-
-    // Restore original PATH
-    env::set_var("PATH", original_path);
+    // Run pr command with draft flag and modified PATH
+    let output = run_test_bin_with_env(path_to_repo, ["pr", "--draft"], vec![("PATH", new_path)]);
 
     let stdout = String::from_utf8_lossy(&output.stdout);
     let stderr = String::from_utf8_lossy(&output.stderr);
@@ -452,13 +443,9 @@ fn test_list_command_with_pr_flag() {
     let original_path = env::var("PATH").unwrap_or_default();
     let absolute_mock_dir = mock_dir.canonicalize().unwrap();
     let new_path = format!("{}:{}", absolute_mock_dir.display(), original_path);
-    env::set_var("PATH", new_path);
-
-    // Run list command with --pr flag
-    let output = run_test_bin(path_to_repo, ["list", "--pr"]);
 
-    // Restore original PATH
-    env::set_var("PATH", original_path);
+    // Run list command with --pr flag, passing the modified PATH
+    let output = run_test_bin_with_env(path_to_repo, ["list", "--pr"], vec![("PATH", new_path)]);
 
     let stdout = String::from_utf8_lossy(&output.stdout);
     let stderr = String::from_utf8_lossy(&output.stderr);
@@ -523,13 +510,9 @@ fn test_status_command_with_pr_flag() {
     let original_path = env::var("PATH").unwrap_or_default();
     let absolute_mock_dir = mock_dir.canonicalize().unwrap();
     let new_path = format!("{}:{}", absolute_mock_dir.display(), original_path);
-    env::set_var("PATH", new_path);
-
-    // Run status command with --pr flag
-    let output = run_test_bin(path_to_repo, ["status", "--pr"]);
 
-    // Restore original PATH
-    env::set_var("PATH", original_path);
+    // Run status command with --pr flag and modified PATH
+    let output = run_test_bin_with_env(path_to_repo, ["status", "--pr"], vec![("PATH", new_path)]);
 
     let stdout = String::from_utf8_lossy(&output.stdout);
     let stderr = String::from_utf8_lossy(&output.stderr);