Skip to content

Commit d8ac781

Browse files
UdjinM6claude
andcommitted
test: fix additional IS lock sync sites that passed nodes=[self.nodes[0]]
wait_for_instantlock(nodes=[self.nodes[0]]) makes the internal sync_mempools a no-op since it only syncs the sender with itself. The MN signer nodes still need the TX, so drop the nodes= restriction to sync all nodes including dynamically added masternodes. Fixes: feature_llmq_singlenode.py (2 sites), feature_notifications.py, interface_zmq_dash.py (governance collateral) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent c79c2d9 commit d8ac781

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

test/functional/feature_llmq_singlenode.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def run_test(self):
106106

107107
self.log.info("Send funds and wait InstantSend lock")
108108
txid = self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), 1)
109-
self.wait_for_instantlock(txid, nodes=[self.nodes[0]])
109+
self.wait_for_instantlock(txid)
110110

111111
self.log.info("Test various options to sign messages with nodes")
112112
recsig_time = self.mocktime
@@ -184,7 +184,7 @@ def run_test(self):
184184
self.wait_for_best_chainlock(self.nodes[0], block_hash)
185185
txid = self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), 1)
186186
self.log.info(f"InstantSend lock on tx: {txid} is expecting")
187-
self.wait_for_instantlock(txid, nodes=[self.nodes[0]])
187+
self.wait_for_instantlock(txid)
188188

189189

190190
if __name__ == '__main__':

test/functional/feature_notifications.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def run_test(self):
139139
tx_count = 10
140140
for _ in range(tx_count):
141141
txid = self.nodes[0].sendtoaddress(self.nodes[1].getnewaddress(), 1)
142-
self.wait_for_instantlock(txid, nodes=[self.nodes[0]])
142+
self.wait_for_instantlock(txid)
143143

144144
# wait at most 10 seconds for expected number of files before reading the content
145145
self.bump_mocktime(30)

test/functional/interface_zmq_dash.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ def test_governance_publishers(self):
381381
}
382382
proposal_hex = ''.join(format(x, '02x') for x in json.dumps(proposal_data).encode())
383383
collateral = self.nodes[0].gobject("prepare", "0", proposal_rev, proposal_time, proposal_hex)
384-
self.wait_for_instantlock(collateral, nodes=[self.nodes[0]])
384+
self.wait_for_instantlock(collateral)
385385
self.generate(self.nodes[0], 6, sync_fun=lambda: self.sync_blocks())
386386
rpc_proposal_hash = self.nodes[0].gobject("submit", "0", proposal_rev, proposal_time, proposal_hex, collateral)
387387
# Validate hashgovernanceobject

0 commit comments

Comments
 (0)