Vivek/poll testnet status ci fix (#743)

* ansible: codify dashmon status monitoring access

* feat: poll testnet status and open infra recovery issues

* fix: shorten dashmon authorized key ansible line

* fix: use tracked testnet node list in poller

---------

Co-authored-by: dashinfraclaw <dashinfraclaw@users.noreply.github.com>

Author: vivekgsharma

lib/testnetStatus/expectedTestnetNodes.json

@@ -0,0 +1,84 @@
+[
+  "masternode-1",
+  "masternode-2",
+  "masternode-3",
+  "masternode-4",
+  "masternode-5",
+  "masternode-6",
+  "masternode-7",
+  "masternode-8",
+  "masternode-9",
+  "masternode-10",
+  "masternode-11",
+  "masternode-12",
+  "masternode-13",
+  "masternode-14",
+  "masternode-15",
+  "masternode-16",
+  "masternode-17",
+  "masternode-18",
+  "masternode-19",
+  "masternode-20",
+  "masternode-21",
+  "masternode-22",
+  "masternode-23",
+  "masternode-24",
+  "masternode-25",
+  "masternode-26",
+  "masternode-27",
+  "masternode-28",
+  "masternode-29",
+  "masternode-30",
+  "masternode-31",
+  "masternode-32",
+  "masternode-33",
+  "masternode-34",
+  "masternode-35",
+  "masternode-36",
+  "masternode-37",
+  "masternode-38",
+  "masternode-39",
+  "masternode-40",
+  "masternode-41",
+  "masternode-42",
+  "masternode-43",
+  "masternode-44",
+  "masternode-45",
+  "masternode-46",
+  "masternode-47",
+  "masternode-48",
+  "masternode-49",
+  "masternode-50",
+  "masternode-51",
+  "masternode-52",
+  "masternode-53",
+  "hp-masternode-1",
+  "hp-masternode-2",
+  "hp-masternode-3",
+  "hp-masternode-4",
+  "hp-masternode-5",
+  "hp-masternode-6",
+  "hp-masternode-7",
+  "hp-masternode-8",
+  "hp-masternode-9",
+  "hp-masternode-10",
+  "hp-masternode-11",
+  "hp-masternode-12",
+  "hp-masternode-13",
+  "hp-masternode-14",
+  "hp-masternode-15",
+  "hp-masternode-16",
+  "hp-masternode-17",
+  "hp-masternode-18",
+  "hp-masternode-19",
+  "hp-masternode-20",
+  "hp-masternode-21",
+  "hp-masternode-22",
+  "hp-masternode-23",
+  "hp-masternode-24",
+  "hp-masternode-25",
+  "hp-masternode-26",
+  "hp-masternode-27",
+  "hp-masternode-28",
+  "hp-masternode-29"
+]

lib/testnetStatus/pollTestnetStatus.js

@@ -5,6 +5,10 @@ const { promisify } = require('util');
 
 const DEFAULT_STATUS_API_URL = 'https://status.testnet.networks.dash.org/api/nodes';
 const DEFAULT_INVENTORY_PATH = path.resolve(process.cwd(), 'networks/testnet.inventory');
+const DEFAULT_EXPECTED_NODE_NAMES_PATH = path.resolve(
+  __dirname,
+  'expectedTestnetNodes.json',
+);
 const DEFAULT_REPOSITORY = 'dashpay/infra';
 const DEFAULT_ASSIGNEE = 'dashinfraclaw';
 const ISSUE_TITLE_PREFIX = '[Testnet Recovery]';
@@ -104,9 +108,27 @@ function filterIncidentsWithoutOpenIssues(incidents, openIssues) {
   return incidents.filter((incident) => !openIssueTitles.has(buildIssueTitle(incident.nodeName)));
 }
 
-async function readExpectedNodeNames(inventoryPath = DEFAULT_INVENTORY_PATH) {
-  const inventoryContents = await fs.readFile(inventoryPath, 'utf8');
-  return parseExpectedNodeNames(inventoryContents);
+async function readExpectedNodeNames(
+  inventoryPath = DEFAULT_INVENTORY_PATH,
+  expectedNodeNamesPath = DEFAULT_EXPECTED_NODE_NAMES_PATH,
+) {
+  try {
+    const inventoryContents = await fs.readFile(inventoryPath, 'utf8');
+    return parseExpectedNodeNames(inventoryContents);
+  } catch (error) {
+    if (error.code !== 'ENOENT') {
+      throw error;
+    }
+
+    const expectedNodeNamesContents = await fs.readFile(expectedNodeNamesPath, 'utf8');
+    const expectedNodeNames = JSON.parse(expectedNodeNamesContents);
+
+    if (!Array.isArray(expectedNodeNames)) {
+      throw new Error('Expected node names fallback must be a JSON array');
+    }
+
+    return expectedNodeNames;
+  }
 }
 
 async function fetchStatusNodes(statusApiUrl = DEFAULT_STATUS_API_URL, fetchImpl = fetch) {
@@ -245,6 +267,7 @@ module.exports = {
   createRecoveryIssue,
   DEFAULT_ASSIGNEE,
   DEFAULT_INVENTORY_PATH,
+  DEFAULT_EXPECTED_NODE_NAMES_PATH,
   DEFAULT_REPOSITORY,
   DEFAULT_STATUS_API_URL,
   fetchStatusNodes,

test/pollTestnetStatus.spec.js

@@ -1,3 +1,6 @@
+const fs = require('fs').promises;
+const os = require('os');
+const path = require('path');
 const { expect } = require('chai');
 
 const {
@@ -7,6 +10,7 @@ const {
   filterIncidentsWithoutOpenIssues,
   findRecoveryIncidents,
   parseExpectedNodeNames,
+  readExpectedNodeNames,
 } = require('../lib/testnetStatus/pollTestnetStatus');
 
 describe('pollTestnetStatus', () => {
@@ -121,6 +125,26 @@ seed-1
     });
   });
 
+  describe('readExpectedNodeNames', () => {
+    it('should fall back to the tracked expected-node list when inventory is missing', async () => {
+      const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'poll-testnet-status-'));
+      const fallbackPath = path.join(tempDir, 'expectedTestnetNodes.json');
+
+      await fs.writeFile(
+        fallbackPath,
+        JSON.stringify(['masternode-1', 'hp-masternode-1']),
+      );
+
+      const expectedNodeNames = await readExpectedNodeNames(
+        path.join(tempDir, 'missing.inventory'),
+        fallbackPath,
+      );
+
+      expect(expectedNodeNames).to.deep.equal(['masternode-1', 'hp-masternode-1']);
+
+      await fs.rm(tempDir, { recursive: true, force: true });
+    });
+  });
   describe('issue helpers', () => {
     it('should use a deterministic issue title and public body', () => {
       expect(buildIssueTitle('hp-masternode-7')).to.equal('[Testnet Recovery] hp-masternode-7');