feat: remove bip30 field from coinstat index

Author: knst

src/index/coinstatsindex.cpp

@@ -144,13 +144,6 @@ bool CoinStatsIndex::WriteBlock(const CBlock& block, const CBlockIndex* pindex)
         for (size_t i = 0; i < block.vtx.size(); ++i) {
             const auto& tx{block.vtx.at(i)};
 
-            // Skip duplicate txid coinbase transactions (BIP30).
-            if (IsBIP30Unspendable(*pindex) && tx->IsCoinBase()) {
-                m_total_unspendable_amount += block_subsidy;
-                m_total_unspendables_bip30 += block_subsidy;
-                continue;
-            }
-
             for (uint32_t j = 0; j < tx->vout.size(); ++j) {
                 const CTxOut& out{tx->vout[j]};
                 Coin coin{out, pindex->nHeight, tx->IsCoinBase()};

src/index/coinstatsindex.h

@@ -32,6 +32,7 @@ class CoinStatsIndex final : public BaseIndex
     CAmount m_total_new_outputs_ex_coinbase_amount{0};
     CAmount m_total_coinbase_amount{0};
     CAmount m_total_unspendables_genesis_block{0};
+    //! There's no unspendable coinbase outputs in dash core. TODO: remove it with a version bump
     CAmount m_total_unspendables_bip30{0};
     CAmount m_total_unspendables_scripts{0};
     CAmount m_total_unspendables_unclaimed_rewards{0};

src/kernel/coinstats.h

@@ -58,7 +58,7 @@ struct CCoinsStats {
     CAmount total_coinbase_amount{0};
     //! The unspendable coinbase amount from the genesis block
     CAmount total_unspendables_genesis_block{0};
-    //! The two unspendable coinbase outputs total amount caused by BIP30
+    //! There's no unspendable coinbase outputs in dash core. TODO: remove it with a version bump
     CAmount total_unspendables_bip30{0};
     //! Total cumulative amount of outputs sent to unspendable scripts (OP_RETURN for example) up to and including this block
     CAmount total_unspendables_scripts{0};

src/rpc/blockchain.cpp

@@ -1171,7 +1171,6 @@ static RPCHelpMan gettxoutsetinfo()
                             {RPCResult::Type::OBJ, "unspendables", "Detailed view of the unspendable categories",
                             {
                                 {RPCResult::Type::STR_AMOUNT, "genesis_block", "The unspendable amount of the Genesis block subsidy"},
-                                {RPCResult::Type::STR_AMOUNT, "bip30", "Transactions overridden by duplicates (no longer possible with BIP30)"},
                                 {RPCResult::Type::STR_AMOUNT, "scripts", "Amounts sent to scripts that are unspendable (for example OP_RETURN outputs)"},
                                 {RPCResult::Type::STR_AMOUNT, "unclaimed_rewards", "Fee rewards that miners did not claim in their coinbase transaction"},
                             }}
@@ -1275,7 +1274,6 @@ static RPCHelpMan gettxoutsetinfo()
 
             UniValue unspendables(UniValue::VOBJ);
             unspendables.pushKV("genesis_block", ValueFromAmount(stats.total_unspendables_genesis_block - prev_stats.total_unspendables_genesis_block));
-            unspendables.pushKV("bip30", ValueFromAmount(stats.total_unspendables_bip30 - prev_stats.total_unspendables_bip30));
             unspendables.pushKV("scripts", ValueFromAmount(stats.total_unspendables_scripts - prev_stats.total_unspendables_scripts));
             unspendables.pushKV("unclaimed_rewards", ValueFromAmount(stats.total_unspendables_unclaimed_rewards - prev_stats.total_unspendables_unclaimed_rewards));
             block_info.pushKV("unspendables", unspendables);

test/functional/feature_coinstatsindex.py

@@ -135,7 +135,6 @@ def _test_coin_stats_index(self):
                 'coinbase': 0,
                 'unspendables': {
                     'genesis_block': 50,
-                    'bip30': 0,
                     'scripts': 0,
                     'unclaimed_rewards': 0
                 }
@@ -152,7 +151,6 @@ def _test_coin_stats_index(self):
                 'coinbase': Decimal('500.00025500'),
                 'unspendables': {
                     'genesis_block': 0,
-                    'bip30': 0,
                     'scripts': 0,
                     'unclaimed_rewards': 0,
                 }
@@ -189,7 +187,6 @@ def _test_coin_stats_index(self):
                 'coinbase': Decimal('500.00101000'),
                 'unspendables': {
                     'genesis_block': 0,
-                    'bip30': 0,
                     'scripts': Decimal('20.99900000'),
                     'unclaimed_rewards': 0,
                 }
@@ -220,7 +217,6 @@ def _test_coin_stats_index(self):
                 'coinbase': 40,
                 'unspendables': {
                     'genesis_block': 0,
-                    'bip30': 0,
                     'scripts': 0,
                     'unclaimed_rewards': 460
                 }