Commit 2f1d59e
committed
Merge #7252: test: fix wait_for_instantlock calls in test_instantsend_after_restart
c885b55 test: fix wait_for_instantlock calls in test_instantsend_after_restart (PastaClaw)
Pull request description:
## Summary
Fix two broken `wait_for_instantlock` call sites in `test_instantsend_after_restart` that were missed during the merge of #7240 and #7241.
## Problem
The merge of #7240 (added `test_instantsend_after_restart` with old-style calls) and #7241 (refactored `wait_for_instantlock(txid, node)` → `wait_for_instantlock(*txids, nodes=None)`) left two call sites using the old positional signature:
```python
for node in self.nodes:
self.wait_for_instantlock(txid, node) # node consumed as second *txid
```
The `node` object gets silently swallowed into `*txids` as a second "txid", causing `getrawtransaction(node_object, True)` to fail and the wait to time out after ~282 seconds. This breaks `p2p_instantsend.py` on every CI run.
## Fix
Replace both loops with the new consolidated API which handles mempool sync and checks all nodes by default:
```python
self.wait_for_instantlock(txid)
```
ACKs for top commit:
PastaPastaPasta:
ACK c885b55
Tree-SHA512: d53c39491ba67697ece0f00393407a1fdc1d87e3bd495d4370c23491f9acef26c8a57bc9085ac007b994adf7903f89fa65e0962f5cbd71b32d4a8dfa2af45d811 file changed
Lines changed: 2 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
| 142 | + | |
146 | 143 | | |
147 | 144 | | |
148 | 145 | | |
| |||
199 | 196 | | |
200 | 197 | | |
201 | 198 | | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
| 199 | + | |
206 | 200 | | |
207 | 201 | | |
208 | 202 | | |
| |||
0 commit comments