refactor: use std23::ranges::fold_left in Dash-specific code

Author: kwvg

src/evo/cbtx.cpp

@@ -2,20 +2,22 @@
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
-#include <consensus/validation.h>
 #include <evo/cbtx.h>
+
 #include <evo/specialtx.h>
 #include <llmq/blockprocessor.h>
 #include <llmq/commitment.h>
 #include <llmq/options.h>
 #include <llmq/quorumsman.h>
 #include <llmq/utils.h>
-#include <node/blockstorage.h>
+#include <util/std23.h>
 
 #include <chain.h>
 #include <chainparams.h>
 #include <consensus/merkle.h>
+#include <consensus/validation.h>
 #include <deploymentstatus.h>
+#include <node/blockstorage.h>
 
 using node::ReadBlockFromDisk;
 
@@ -109,11 +111,7 @@ auto CachedGetQcHashesQcIndexedHashes(const CBlockIndex* pindexPrev, const llmq:
 
 auto CalcHashCountFromQCHashes(const QcHashMap& qcHashes)
 {
-    size_t hash_count{0};
-    for (const auto& [_, vec_hashes] : qcHashes) {
-        hash_count += vec_hashes.size();
-    }
-    return hash_count;
+    return std23::ranges::fold_left(qcHashes, size_t{0}, [](size_t s, const auto& p) { return s + p.second.size(); });
 }
 
 bool CalcCbTxMerkleRootQuorums(const CBlock& block, const CBlockIndex* pindexPrev,

src/governance/classes.cpp

@@ -233,14 +233,7 @@ bool CSuperblock::GetPayment(int nPaymentIndex, CGovernancePayment& paymentRet)
 
 CAmount CSuperblock::GetPaymentsTotalAmount()
 {
-    CAmount nPaymentsTotalAmount = 0;
-    int nPayments = CountPayments();
-
-    for (int i = 0; i < nPayments; i++) {
-        nPaymentsTotalAmount += vecPayments[i].nAmount;
-    }
-
-    return nPaymentsTotalAmount;
+    return std23::ranges::fold_left(vecPayments, CAmount{0}, [](CAmount s, const auto& p) { return s + p.nAmount; });
 }
 
 /**

src/llmq/signing_shares.cpp

@@ -313,10 +313,9 @@ void CSigSharesManager::ProcessMessage(const CNode& pfrom, const std::string& ms
     } else if (msg_type == NetMsgType::QBSIGSHARES) {
         std::vector<CBatchedSigShares> msgs;
         vRecv >> msgs;
-        size_t totalSigsCount = 0;
-        for (const auto& bs : msgs) {
-            totalSigsCount += bs.sigShares.size();
-        }
+        const size_t totalSigsCount = std23::ranges::fold_left(msgs, size_t{0}, [](size_t s, const auto& bs) {
+            return s + bs.sigShares.size();
+        });
         if (totalSigsCount > MAX_MSGS_TOTAL_BATCHED_SIGS) {
             LogPrint(BCLog::LLMQ_SIGS, "CSigSharesManager::%s -- too many sigs in QBSIGSHARES message. cnt=%d, max=%d, node=%d\n", __func__, msgs.size(), MAX_MSGS_TOTAL_BATCHED_SIGS, pfrom.GetId());
             BanNode(pfrom.GetId());

src/llmq/signing_shares.h

@@ -11,6 +11,7 @@
 #include <llmq/signhash.h>
 #include <llmq/signing.h>
 #include <msg_result.h>
+#include <util/std23.h>
 
 #include <random.h>
 #include <saltedhasher.h>
@@ -231,11 +232,8 @@ class SigShareMap
 
     [[nodiscard]] size_t Size() const
     {
-        size_t s = 0;
-        for (auto& p : internalMap) {
-            s += p.second.size();
-        }
-        return s;
+        return std23::ranges::fold_left(internalMap, size_t{0},
+                                        [](size_t s, const auto& p) { return s + p.second.size(); });
     }
 
     [[nodiscard]] size_t CountForSignHash(const uint256& signHash) const