Skip to content

Commit 4337810

Browse files
knstMarcoFalke
andcommitted
Merge bitcoin#26954: test: Avoid rpc timeout in p2p_headers_sync_with_minchainwork
fa952fa test: Avoid rpc timeout in p2p_headers_sync_with_minchainwork (MarcoFalke) Pull request description: When running a lot of tests in parallel, I get `JSONRPCException: 'generatetoaddress' RPC took longer than 30.000000 seconds.` The general recommendation, if running into timeouts, is to increase the `--timeout-factor`. However, I think that the default timeout values should be suitable to run the tests out of the box on reasonable hardware. ACKs for top commit: fanquake: ACK fa952fa Tree-SHA512: b7eeda54f8db900f077417c0431f659c67e686e2fc078f8c713e37ed75b8bc862814ce20e8400741638e35e224d7284ad16172bf5f82168f803376d0c9ec4524 Co-authored-by: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
1 parent cd45c5d commit 4337810

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

test/functional/p2p_headers_sync_with_minchainwork.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929

3030
class RejectLowDifficultyHeadersTest(BitcoinTestFramework):
3131
def set_test_params(self):
32+
self.rpc_timeout *= 4 # To avoid timeout when generating BLOCKS_TO_MINE
3233
self.setup_clean_chain = True
3334
self.num_nodes = 4
3435
# Node0 has no required chainwork; node1 requires 15 blocks on top of the genesis block; node2 requires 2047

0 commit comments

Comments
 (0)