refactor: drop unused m_quorums_watch member from NetDKG

The NetDKG::m_quorums_watch member was stored by both constructors but
never read: the active path forwards quorums_watch into each
ActiveDKGSessionHandler (feeding the live QuorumsWatch() accessor),
while NetDKG's own copy was dead. Remove the member, drop the now-unused
quorums_watch parameter from the observer-mode constructor (and its
init.cpp call site), and keep it on the active-mode constructor where it
is still forwarded to the handler.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: 2 people

src/init.cpp

@@ -2241,7 +2241,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
             *node.active_ctx->nodeman, *node.connman));
     } else if (node.observer_ctx) {
         node.peerman->AddExtraHandler(std::make_unique<llmq::NetDKG>(
-            node.peerman.get(), *node.sporkman, *node.observer_ctx->qdkgsman, chainman, /*quorums_watch=*/true,
+            node.peerman.get(), *node.sporkman, *node.observer_ctx->qdkgsman, chainman,
             *node.llmq_ctx->qman, *node.observer_ctx));
     } else {
         node.peerman->AddExtraHandler(std::make_unique<llmq::NetDKGStub>(node.peerman.get()));

src/llmq/net_dkg.cpp

@@ -216,13 +216,12 @@ bool ProcessPendingMessageBatch(const CConnman& connman, CDKGSession& session, C
 
 
 NetDKG::NetDKG(PeerManagerInternal* peer_manager, const CSporkManager& sporkman, CDKGSessionManager& qdkgsman,
-               const ChainstateManager& chainman, bool quorums_watch, CQuorumManager& qman, QuorumRole& role) :
+               const ChainstateManager& chainman, CQuorumManager& qman, QuorumRole& role) :
     NetHandler(peer_manager),
     m_qdkgsman{qdkgsman},
     m_qman{qman},
     m_sporkman{sporkman},
     m_chainman{chainman},
-    m_quorums_watch{quorums_watch},
     m_active{nullptr}
 {
     m_qdkgsman.InitializeHandlers([](const Consensus::LLMQParams& llmq_params,
@@ -242,7 +241,6 @@ NetDKG::NetDKG(PeerManagerInternal* peer_manager, const CSporkManager& sporkman,
     m_qman{qman},
     m_sporkman{sporkman},
     m_chainman{chainman},
-    m_quorums_watch{quorums_watch},
     m_active{std::make_unique<ActiveDKG>(ActiveDKG{dmnman, mn_metaman, dkgdbgman, qblockman, qsnapman, connman})}
 {
     m_qdkgsman.InitializeHandlers(

src/llmq/net_dkg.h

@@ -54,7 +54,7 @@ class NetDKG final : public NetHandler
 public:
     //! Observer-mode constructor.
     NetDKG(PeerManagerInternal* peer_manager, const CSporkManager& sporkman, CDKGSessionManager& qdkgsman,
-           const ChainstateManager& chainman, bool quorums_watch, CQuorumManager& qman, QuorumRole& role);
+           const ChainstateManager& chainman, CQuorumManager& qman, QuorumRole& role);
 
     //! Active-mode constructor: takes the masternode-only dep bundle as required references.
     NetDKG(PeerManagerInternal* peer_manager, const CSporkManager& sporkman, CDKGSessionManager& qdkgsman,
@@ -96,7 +96,6 @@ class NetDKG final : public NetHandler
     CQuorumManager& m_qman;
     const CSporkManager& m_sporkman;
     const ChainstateManager& m_chainman;
-    const bool m_quorums_watch;
     const std::unique_ptr<ActiveDKG> m_active; //!< null in observer mode, non-null in active mode
 
     /** Cache: quorum hash → quorum index, populated lazily by ProcessMessage. */