refactor: address review feedback on spork ProcessMessage refactor

- Use __func__ in IsSporkValid log prefixes (was stale "ProcessSpork")
- Mark IsSporkValid as const
- Pass reason string to Misbehaving on invalid spork

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: 2 people

src/net_processing.cpp

@@ -5470,7 +5470,7 @@ void PeerManagerImpl::ProcessMessage(
         CInv spork_inv{MSG_SPORK, hash};
         WITH_LOCK(::cs_main, EraseObjectRequest(pfrom.GetId(), spork_inv));
         if (!m_sporkman.IsSporkValid(spork)) {
-            Misbehaving(pfrom.GetId(), 100);
+            Misbehaving(pfrom.GetId(), 100, strprintf("invalid spork received. peer=%d", pfrom.GetId()));
             return;
         }
         if (m_sporkman.ProcessSpork(spork)) {

src/spork.cpp

@@ -123,17 +123,17 @@ void CSporkManager::CheckAndRemove()
     }
 }
 
-bool CSporkManager::IsSporkValid(const CSporkMessage& spork)
+bool CSporkManager::IsSporkValid(const CSporkMessage& spork) const
 {
     if (spork.nTimeSigned > GetAdjustedTime() + 2 * 60 * 60) {
-        LogPrint(BCLog::SPORK, "CSporkManager::ProcessSpork -- ERROR: too far into the future\n");
+        LogPrint(BCLog::SPORK, "CSporkManager::%s -- ERROR: too far into the future\n", __func__);
         return false;
     }
 
     auto opt_keyIDSigner = spork.GetSignerKeyID();
 
     if (opt_keyIDSigner == std::nullopt || WITH_LOCK(cs, return !setSporkPubKeyIDs.count(*opt_keyIDSigner))) {
-        LogPrint(BCLog::SPORK, "CSporkManager::ProcessSpork -- ERROR: invalid signature\n");
+        LogPrint(BCLog::SPORK, "CSporkManager::%s -- ERROR: invalid signature\n", __func__);
         return false;
     }
     return true;

src/spork.h

@@ -248,7 +248,7 @@ class CSporkManager : public SporkStore
      * If these values mismatch function returns false [spork is invalid]
      * If spork validation failed, peer should be punished
      */
-    [[nodiscard]] bool IsSporkValid(const CSporkMessage& spork) EXCLUSIVE_LOCKS_REQUIRED(!cs);
+    [[nodiscard]] bool IsSporkValid(const CSporkMessage& spork) const EXCLUSIVE_LOCKS_REQUIRED(!cs);
     /**
      * ProcessSpork is used to handle the 'spork' p2p message.
      *