Merge #7246: test: add functional tests for -deprecatedrpc=permissive_bool

02c4ed4 test: expand permissive_bool test coverage (UdjinM6)
00d18f8 test: add functional tests for -deprecatedrpc=permissive_bool (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented
  Follow-up for #7099

  ## What was done?
  Added functional tests for #7099

  ## How Has This Been Tested?
  See new functional tests inside `rpc_deprecated.py`

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK 02c4ed4

Tree-SHA512: 758cb89d4f9afa20171084b7ded8054177266539ea7ca0e868ce77ab5b62b151340ec98465632743caa22acd5f61d5d6dca3bb128c9f4887a48d4f43694c8ecf

Author: PastaPastaPasta

test/functional/rpc_deprecated.py

@@ -4,13 +4,13 @@
 # file COPYING or http://www.opensource.org/licenses/mit-license.php.
 """Test deprecation of RPC calls."""
 from test_framework.test_framework import BitcoinTestFramework
-# from test_framework.util import assert_raises_rpc_error
+from test_framework.util import assert_raises_rpc_error, assert_equal
 
 class DeprecatedRpcTest(BitcoinTestFramework):
     def set_test_params(self):
         self.num_nodes = 2
         self.setup_clean_chain = True
-        self.extra_args = [[], []]
+        self.extra_args = [[], ["-deprecatedrpc=permissive_bool"]]
 
     def run_test(self):
         # This test should be used to verify correct behaviour of deprecated
@@ -23,7 +23,40 @@ def run_test(self):
         # self.log.info("Test generate RPC")
         # assert_raises_rpc_error(-32, 'The wallet generate rpc method is deprecated', self.nodes[0].rpc.generate, 1)
         # self.generate(self.nodes[1], 1)
-        self.log.info("No tested deprecated RPC methods")
+        # self.log.info("No tested deprecated RPC methods")
+        self.test_permissive_bool()
+
+    def test_permissive_bool(self):
+        self.log.info("Test -deprecatedrpc=permissive_bool")
+        self.generate(self.nodes[0], 1)
+
+        self.log.info("Node 0 (strict): JSON boolean accepted, legacy types rejected")
+        assert_equal([], self.nodes[0].protx("list", "valid", True))
+        assert_equal([], self.nodes[0].protx("list", "valid", False))
+        assert_raises_rpc_error(-8, 'detailed must be a JSON boolean. Pass -deprecatedrpc=permissive_bool to allow legacy boolean parsing.', self.nodes[0].protx, "list", "valid", 1)
+        assert_raises_rpc_error(-8, 'detailed must be a JSON boolean. Pass -deprecatedrpc=permissive_bool to allow legacy boolean parsing.', self.nodes[0].protx, "list", "valid", "1")
+        assert_raises_rpc_error(-8, 'detailed must be a JSON boolean. Pass -deprecatedrpc=permissive_bool to allow legacy boolean parsing.', self.nodes[0].protx, "list", "valid", 0)
+        assert_raises_rpc_error(-8, 'detailed must be a JSON boolean. Pass -deprecatedrpc=permissive_bool to allow legacy boolean parsing.', self.nodes[0].protx, "list", "valid", "0")
+        assert_raises_rpc_error(-8, 'detailed must be a JSON boolean. Pass -deprecatedrpc=permissive_bool to allow legacy boolean parsing.', self.nodes[0].protx, "list", "valid", "true")
+        assert_raises_rpc_error(-8, 'detailed must be a JSON boolean. Pass -deprecatedrpc=permissive_bool to allow legacy boolean parsing.', self.nodes[0].protx, "list", "valid", "false")
+        assert_raises_rpc_error(-8, 'detailed must be a JSON boolean. Pass -deprecatedrpc=permissive_bool to allow legacy boolean parsing.', self.nodes[0].protx, "list", "valid", "yes")
+        assert_raises_rpc_error(-8, 'detailed must be a JSON boolean. Pass -deprecatedrpc=permissive_bool to allow legacy boolean parsing.', self.nodes[0].protx, "list", "valid", "no")
+
+        self.log.info("Node 1 (permissive): JSON boolean and legacy types accepted")
+        assert_equal([], self.nodes[1].protx("list", "valid", True))
+        assert_equal([], self.nodes[1].protx("list", "valid", 1))
+        assert_equal([], self.nodes[1].protx("list", "valid", "1"))
+        assert_equal([], self.nodes[1].protx("list", "valid", False))
+        assert_equal([], self.nodes[1].protx("list", "valid", 0))
+        assert_equal([], self.nodes[1].protx("list", "valid", "0"))
+        assert_equal([], self.nodes[1].protx("list", "valid", "true"))
+        assert_equal([], self.nodes[1].protx("list", "valid", "false"))
+        assert_equal([], self.nodes[1].protx("list", "valid", "yes"))
+        assert_equal([], self.nodes[1].protx("list", "valid", "no"))
+
+        self.log.info("Node 1 (permissive): invalid values still rejected")
+        assert_raises_rpc_error(-8, "detailed must be true, false, yes, no, 1 or 0 (not '2')", self.nodes[1].protx, "list", "valid", 2)
+        assert_raises_rpc_error(-8, "detailed must be true, false, yes, no, 1 or 0 (not 'notabool')", self.nodes[1].protx, "list", "valid", "notabool")
 
 if __name__ == '__main__':
     DeprecatedRpcTest().main()