Skip to content

Commit e652406

Browse files
achow101vijaydasmp
authored andcommitted
Merge bitcoin#28980: rpc: encryptwallet help, mention HD seed rotation and backup requirement
ca09415 rpc, doc: encryptwallet, mention HD seed rotation and new backup (furszy) Pull request description: Small and simple PR, updating the `encryptwallet` help message. Better to notify users about the HD seed rotation and the new backup requirement before executing the encryption process. Ensuring they are prepared to update previous backups and securely safeguard the updated wallet file. ACKs for top commit: S3RK: ACK ca09415 achow101: ACK ca09415 Tree-SHA512: f0ee65f5cea66450566e3a85e066d4c06b3293dd0e0b2ed5fafdb7fb11da0a2cd94407299a3c57a0706c2ed782f8eabb73443e85d8099a62a3fb10a02636ab46
1 parent 4cc2103 commit e652406

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

src/wallet/rpc/encrypt.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,11 @@ RPCHelpMan encryptwallet()
220220
"After this, any calls that interact with private keys such as sending or signing \n"
221221
"will require the passphrase to be set prior the making these calls.\n"
222222
"Use the walletpassphrase call for this, and then walletlock call.\n"
223-
"If the wallet is already encrypted, use the walletpassphrasechange call.\n",
223+
"If the wallet is already encrypted, use the walletpassphrasechange call.\n"
224+
"** IMPORTANT **\n"
225+
"For security reasons, the encryption process will generate a new HD seed, resulting\n"
226+
"in the creation of a fresh set of active descriptors. Therefore, it is crucial to\n"
227+
"securely back up the newly generated wallet file using the backupwallet RPC.\n",
224228
{
225229
{"passphrase", RPCArg::Type::STR, RPCArg::Optional::NO, "The pass phrase to encrypt the wallet with. It must be at least 1 character, but should be long."},
226230
},
@@ -266,7 +270,7 @@ RPCHelpMan encryptwallet()
266270
if (pwallet->IsHDEnabled()) {
267271
return "wallet encrypted; If you forget the passphrase, you will lose access to your funds. Make sure that you have backup of your seed or mnemonic.";
268272
}
269-
return "wallet encrypted; The keypool has been flushed. You need to make a new backup.";
273+
return "wallet encrypted; The keypool has been flushed. You need to make a new backup with the backupwallet RPC.";
270274
},
271275
};
272276
}

0 commit comments

Comments
 (0)