Skip to content

fix(qt): make governance search case-insensitive#7297

Draft
thepastaclaw wants to merge 1 commit intodashpay:developfrom
thepastaclaw:fix/governance-search-case-insensitive
Draft

fix(qt): make governance search case-insensitive#7297
thepastaclaw wants to merge 1 commit intodashpay:developfrom
thepastaclaw:fix/governance-search-case-insensitive

Conversation

@thepastaclaw
Copy link
Copy Markdown

PR description

Summary

  • Make the Governance proposals title filter case-insensitive.
  • Match the behavior already used by other Qt search/filter views.

Closes #7287.

Validation

  • git diff --check
  • Pre-PR review gate: ship
  • Not run: full build / GUI smoke test; no build directory was available in
    this worktree.

@thepastaclaw
Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions
Copy link
Copy Markdown

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d43df620-5f99-4d47-afc2-f5951962b64b

📥 Commits

Reviewing files that changed from the base of the PR and between 7e524b1 and c318e57.

📒 Files selected for processing (1)
  • src/qt/proposallist.cpp

Walkthrough

The proposal list filtering in src/qt/proposallist.cpp is modified to perform case-insensitive matching when filtering against the title column. The QSortFilterProxyModel is configured with a case-insensitive filter, while the filter string binding and proxy model setup remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: making governance search case-insensitive in the Qt UI.
Description check ✅ Passed The description clearly relates to the changeset, explaining the case-insensitive filter implementation and referencing the closed issue.
Linked Issues check ✅ Passed The code change implements case-insensitive filtering for governance proposals, directly addressing issue #7287's requirement for case-insensitive substring search.
Out of Scope Changes check ✅ Passed The single line change to proposallist.cpp only modifies the case sensitivity behavior of the governance proposals filter, which is directly within scope of issue #7287.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@thepastaclaw
Copy link
Copy Markdown
Author

thepastaclaw commented Apr 29, 2026

✅ Review complete (commit c318e57)

Copy link
Copy Markdown
Author

@thepastaclaw thepastaclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Single-line Qt fix making the governance proposal title filter case-insensitive via setFilterCaseSensitivity(Qt::CaseInsensitive). Both reviewers independently found no issues; the change matches the established pattern used elsewhere in the Qt code (transactionview.cpp, masternodelist.cpp, addressbookpage.cpp).

Reviewed commit: c318e57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] - Governanace tab make search case insensitive

1 participant