chore: some dashpay adjustments#698
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the DashWallet project, focusing on improving sync-related functionality, enhancing platform support, and addressing minor issues. The most significant changes include updates to sync progress tracking, refinements to masternode and platform sync information, and configuration adjustments for the build process.
Sync Progress and Activity Updates:
SyncingActivityMonitorto replace references tomodel.combinedSyncProgresswithmodel.progressfor more accurate progress tracking. [1] [2] [3]peerManagerConnectedproperty to usemodel.peersSyncInfo.peerManagerConnectedfor better encapsulation. [1] [2]Masternode and Platform Sync Refinements:
queueCountandqueueMaxAmountinstead ofretrievalQueueCountandretrievalQueueMaxAmountfor consistency. [1] [2]queueCountandqueueMaxAmountinSyncingAlertContentView.Build Configuration Enhancements:
DASHCORE_QUORUM_VALIDATION,DPP_STATE_TRANSITIONS,PLATFORM_VALUE_STD) to thePodfileto enable specific platform features during the build process.Minor Fixes and Adjustments:
DSChaininitialization inDWReceiveModelStubto explicitly useDSChain.testnet.NSAssertinDWDashPayModelto prevent runtime crashes when the username is empty.