Skip to content

chore: some dashpay adjustments#698

Merged
pankcuf merged 1 commit into
developfrom
feat/dashpay-adjustments
Apr 22, 2025
Merged

chore: some dashpay adjustments#698
pankcuf merged 1 commit into
developfrom
feat/dashpay-adjustments

Conversation

@pankcuf
Copy link
Copy Markdown
Contributor

@pankcuf pankcuf commented Apr 22, 2025

This pull request introduces several updates to the DashWallet project, focusing on improving sync-related functionality, enhancing platform support, and addressing minor issues. The most significant changes include updates to sync progress tracking, refinements to masternode and platform sync information, and configuration adjustments for the build process.

Sync Progress and Activity Updates:

  • Updated SyncingActivityMonitor to replace references to model.combinedSyncProgress with model.progress for more accurate progress tracking. [1] [2] [3]
  • Modified the peerManagerConnected property to use model.peersSyncInfo.peerManagerConnected for better encapsulation. [1] [2]

Masternode and Platform Sync Refinements:

  • Updated masternode sync properties to use queueCount and queueMaxAmount instead of retrievalQueueCount and retrievalQueueMaxAmount for consistency. [1] [2]
  • Added support for platform sync progress, including new properties for queueCount and queueMaxAmount in SyncingAlertContentView.

Build Configuration Enhancements:

  • Added preprocessor definitions (DASHCORE_QUORUM_VALIDATION, DPP_STATE_TRANSITIONS, PLATFORM_VALUE_STD) to the Podfile to enable specific platform features during the build process.

Minor Fixes and Adjustments:

  • Changed DSChain initialization in DWReceiveModelStub to explicitly use DSChain.testnet.
  • Commented out an NSAssert in DWDashPayModel to prevent runtime crashes when the username is empty.

@pankcuf pankcuf requested a review from Syn-McJ April 22, 2025 09:14
Copy link
Copy Markdown
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pankcuf pankcuf merged commit b0c24b5 into develop Apr 22, 2025
1 check passed
@pankcuf pankcuf deleted the feat/dashpay-adjustments branch April 23, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants