Skip to content

Feat/private note#699

Merged
Syn-McJ merged 10 commits into
dashpay:developfrom
Syn-McJ:feat/private-note
Apr 28, 2025
Merged

Feat/private note#699
Syn-McJ merged 10 commits into
dashpay:developfrom
Syn-McJ:feat/private-note

Conversation

@Syn-McJ
Copy link
Copy Markdown
Member

@Syn-McJ Syn-McJ commented Apr 28, 2025

Issue being fixed or feature implemented

We need the ability to save a private memo as transaction metadata.

What was done?

  • Private memo UI
  • Saving private memo in the database
  • Displaying private memo

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf April 28, 2025 08:59
@Syn-McJ Syn-McJ self-assigned this Apr 28, 2025

func cleanUp() {
TxUserInfoDAOImpl.shared.deleteAll()
TransactionMetadataDAOImpl.shared.deleteAll()
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TxUserInfoDAOImpl renamed to align with Android

Copy link
Copy Markdown
Contributor

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit 8fcad99 into dashpay:develop Apr 28, 2025
1 check failed
@Syn-McJ Syn-McJ deleted the feat/private-note branch April 28, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants