feat(dashspend): buy gift card UI#701
Merged
Syn-McJ merged 15 commits intoMay 19, 2025
Merged
Conversation
Release: 8.3.3
docs: add release badge
There was a problem hiding this comment.
Pull Request Overview
This PR implements the new gift card buying UI for DashSpend by introducing new SwiftUI components and refactoring parts of the HomeView architecture. Key changes include injecting a HomeViewModel into HomeView, converting HomeBalanceView from a UIKit view to a SwiftUI view, and adding new DashSpendPay UI components and view models; additionally, merchant data has been updated to use savingsBasisPoints.
Reviewed Changes
Copilot reviewed 90 out of 90 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DashWallet/Sources/UI/Home/Views/HomeView.swift | Updated to accept HomeViewModel via initializer and removed obsolete DWHomeModelUpdatesObserver methods. |
| DashWallet/Sources/UI/Home/Views/Home Header View/HomeHeaderView.swift | Adjusted initializer and view setup to remove balanceView dependency. |
| DashWallet/Sources/UI/Home/Views/Home Balance View/HomeBalanceView.swift | Converted from a UIView-based implementation to a SwiftUI view with gesture handling updated accordingly. |
| DashWallet/Sources/UI/Explore Dash/Views/DashSpend/DashSpendPayViewModel.swift | New view model for DashSpendPay features with minor naming inconsistency. |
| (Multiple additional files) | New UI components and updated logic for DashSpend feature integration and merchant savings representation. |
Comments suppressed due to low confidence (1)
DashWallet/Sources/UI/Explore Dash/Views/DashSpend/DashSpendPayViewModel.swift:80
- Consider renaming 'maximumimit' to 'maximumLimit' for clarity and consistency.
var maximumimit: String { String.localizedStringWithFormat(NSLocalizedString("Max: %@", comment: "DashSpend"), fiatFormatter.string(for: maximumAmount) ?? "0.0" ) }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
After DashSpend login, the user should be redirected to the payment screen for buying the gift card.
What was done?
How Has This Been Tested?
QA
Breaking Changes
Checklist:
For repository code-owners and collaborators only