Skip to content

fix: deeplink from camera & balance auth#702

Merged
Syn-McJ merged 2 commits into
dashpay:masterfrom
Syn-McJ:fix/quick-scan
May 20, 2025
Merged

fix: deeplink from camera & balance auth#702
Syn-McJ merged 2 commits into
dashpay:masterfrom
Syn-McJ:fix/quick-scan

Conversation

@Syn-McJ

@Syn-McJ Syn-McJ commented May 17, 2025

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

  • When scanning a Dash QR code with the camera app, the result is immediate confirmation without ability to modify the amount and without the "Insufficient funds" error being displayed.
  • When scanning Dash QR from the app's lockscreen, the full balance can be revealed without authenticating.

What was done?

  • Treat URL payment request the same as QR request, i.e., redirect user to "Send" screen.
  • Request authentication for balance reveal

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested review from Copilot and pankcuf May 17, 2025 07:45
@Syn-McJ Syn-McJ self-assigned this May 17, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues related to how deep linking from the camera and lockscreen handles QR and URL payment requests by enforcing authentication before revealing balance details.

  • Updated the SendIntro SwiftUI component to include an authCallback for secure balance toggling.
  • Modified DWPaymentProcessor to treat URL payment requests the same as QR requests.
  • Updated ProvideAmountViewController to pass the authCallback to SendIntro.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
DashWallet/Sources/UI/SwiftUI Components/SendIntro.swift Added authCallback property and updated toggle logic for secure balance reveal.
DashWallet/Sources/UI/Payments/PaymentModels/DWPaymentProcessor.m Updated condition to process URL payment requests similarly to QR requests.
DashWallet/Sources/UI/Payment Controller/Enter Amount/ProvideAmountViewController.swift Passed the authCallback from the model to the SendIntro component.

Comment thread DashWallet/Sources/UI/SwiftUI Components/SendIntro.swift

@pankcuf pankcuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit 11299c6 into dashpay:master May 20, 2025
@Syn-McJ Syn-McJ deleted the fix/quick-scan branch May 20, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants