Skip to content

feat(dashspen): redeem card#706

Merged
Syn-McJ merged 10 commits into
dashpay:feature/dashspendfrom
Syn-McJ:feat/dashspend-redeem-card
Jun 5, 2025
Merged

feat(dashspen): redeem card#706
Syn-McJ merged 10 commits into
dashpay:feature/dashspendfrom
Syn-McJ:feat/dashspend-redeem-card

Conversation

@Syn-McJ
Copy link
Copy Markdown
Member

@Syn-McJ Syn-McJ commented Jun 4, 2025

Issue being fixed or feature implemented

After the gift card is purchased, we want to present the gift card details (barcode, pin code, etc).

What was done?

  • Gift card database table
  • Saving gift card dummy after the purchase
  • Querying the backend for the full gift card
  • Displaying full gift card info in the UI
  • Some Obj-C -> Swift refactoring

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf June 4, 2025 12:41
@Syn-McJ Syn-McJ self-assigned this Jun 4, 2025
Copy link
Copy Markdown
Contributor

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit 948bbc3 into dashpay:feature/dashspend Jun 5, 2025
1 check failed
@Syn-McJ Syn-McJ deleted the feat/dashspend-redeem-card branch June 5, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants