Skip to content

fix(dashspend): robust Explore DB v3 upgrade#708

Merged
Syn-McJ merged 2 commits into
dashpay:feature/dashspendfrom
Syn-McJ:fix/dashspend-v3-db
Jun 12, 2025
Merged

fix(dashspend): robust Explore DB v3 upgrade#708
Syn-McJ merged 2 commits into
dashpay:feature/dashspendfrom
Syn-McJ:fix/dashspend-v3-db

Conversation

@Syn-McJ
Copy link
Copy Markdown
Member

@Syn-McJ Syn-McJ commented Jun 12, 2025

Issue being fixed or feature implemented

  • If the app didn't update to v3 Explore database prior to the user opening the Explore feature, the app will crash due to a schema mismatch.

What was done?

  • Check the DB schema, don't connect if old
  • Wait for new DB download
  • Show "data is syncing" notification
  • Reload search results once DB is ready

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf June 12, 2025 04:42
@Syn-McJ Syn-McJ self-assigned this Jun 12, 2025
Copy link
Copy Markdown
Contributor

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit d6cb9fc into dashpay:feature/dashspend Jun 12, 2025
1 check failed
@Syn-McJ Syn-McJ deleted the fix/dashspend-v3-db branch June 12, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants