Skip to content

feat(dashspend): fixed denominations#711

Merged
Syn-McJ merged 6 commits into
dashpay:feature/dashspendfrom
Syn-McJ:feat/dashspend-fixed-denoms
Jun 28, 2025
Merged

feat(dashspend): fixed denominations#711
Syn-McJ merged 6 commits into
dashpay:feature/dashspendfrom
Syn-McJ:feat/dashspend-fixed-denoms

Conversation

@Syn-McJ
Copy link
Copy Markdown
Member

@Syn-McJ Syn-McJ commented Jun 23, 2025

Issue being fixed or feature implemented

We want to support fixed denomination merchants.

What was done?

  • UI for fixed denominations
  • Refactoring to allow updating merchant info before opening the Buy screen
  • Network reachability and error handlers
  • Align text with Android

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf June 23, 2025 06:49
@Syn-McJ Syn-McJ self-assigned this Jun 23, 2025
@Syn-McJ
Copy link
Copy Markdown
Member Author

Syn-McJ commented Jun 26, 2025

@CodeRabbit review

@Syn-McJ Syn-McJ removed the request for review from pankcuf June 27, 2025 10:13
Copy link
Copy Markdown
Contributor

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit cd7e2b2 into dashpay:feature/dashspend Jun 28, 2025
1 check failed
@Syn-McJ Syn-McJ deleted the feat/dashspend-fixed-denoms branch June 28, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants