Skip to content

feat(dashspend): piggycards terms and conditions#714

Merged
Syn-McJ merged 1 commit into
dashpay:feature/piggycardsfrom
Syn-McJ:feat/piggycard-terms
Jul 2, 2025
Merged

feat(dashspend): piggycards terms and conditions#714
Syn-McJ merged 1 commit into
dashpay:feature/piggycardsfrom
Syn-McJ:feat/piggycard-terms

Conversation

@Syn-McJ
Copy link
Copy Markdown
Member

@Syn-McJ Syn-McJ commented Jun 30, 2025

Issue being fixed or feature implemented

Similar to dashpay/dash-wallet#1405, we need to provide PiggyCards login dialog with their terms and conditions

What was done?

  • Rename CTX -> DashSpend where makes sense
  • Add UI support for multiple gift card providers

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from HashEngineering June 30, 2025 07:10
@Syn-McJ Syn-McJ self-assigned this Jun 30, 2025
@Syn-McJ
Copy link
Copy Markdown
Member Author

Syn-McJ commented Jun 30, 2025

@CodeRabbit review

Copy link
Copy Markdown
Contributor

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit eead657 into dashpay:feature/piggycards Jul 2, 2025
1 check failed
@Syn-McJ Syn-McJ deleted the feat/piggycard-terms branch July 2, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants